Re: [Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

2018-03-27 Thread Emilio G. Cota
On Tue, Mar 27, 2018 at 12:41:18 +0100, Alex Bennée wrote: > > Emilio G. Cota writes: > > > On Thu, Mar 22, 2018 at 14:41:05 +0800, Richard Henderson wrote: > > (snip) > >> Another thought re all of the soft_is_normal || soft_is_zero checks that > >> you're > >> performing. I think it would be

Re: [Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

2018-03-27 Thread Alex Bennée
Emilio G. Cota writes: > On Thu, Mar 22, 2018 at 14:41:05 +0800, Richard Henderson wrote: > (snip) >> Another thought re all of the soft_is_normal || soft_is_zero checks that >> you're >> performing. I think it would be nice if we could work with >> float*_unpack_canonical so that we don't hav

Re: [Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

2018-03-22 Thread Emilio G. Cota
On Thu, Mar 22, 2018 at 14:41:05 +0800, Richard Henderson wrote: (snip) > Another thought re all of the soft_is_normal || soft_is_zero checks that > you're > performing. I think it would be nice if we could work with > float*_unpack_canonical so that we don't have to duplicate work. E.g. > > /*

Re: [Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

2018-03-22 Thread Laurent Vivier
Le 22/03/2018 à 16:08, Emilio G. Cota a écrit : > On Thu, Mar 22, 2018 at 14:41:05 +0800, Richard Henderson wrote: >> On 03/22/2018 01:57 PM, Emilio G. Cota wrote: Is there any especially good reason you want to not put this code into the normal softfloat function? Does it really many an

Re: [Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

2018-03-22 Thread Emilio G. Cota
On Thu, Mar 22, 2018 at 14:41:05 +0800, Richard Henderson wrote: > On 03/22/2018 01:57 PM, Emilio G. Cota wrote: > >> Is there any especially good reason you want to not put this code into the > >> normal softfloat function? Does it really many any measurable difference > >> at > >> all to force

Re: [Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

2018-03-21 Thread Richard Henderson
On 03/22/2018 01:57 PM, Emilio G. Cota wrote: >> Is there any especially good reason you want to not put this code into the >> normal softfloat function? Does it really many any measurable difference at >> all to force this code to be inlined into a helper? > > You mean to do this? (... or see be

Re: [Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

2018-03-21 Thread Emilio G. Cota
On Thu, Mar 22, 2018 at 13:05:00 +0800, Richard Henderson wrote: > On 03/22/2018 04:11 AM, Emilio G. Cota wrote: > > +#define GEN_FPU_ADDSUB(add_name, sub_name, soft_t, host_t, \ > > + host_abs_func, min_normal) \ > > +static inline __att

Re: [Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

2018-03-21 Thread Richard Henderson
On 03/22/2018 04:11 AM, Emilio G. Cota wrote: > +#define GEN_FPU_ADDSUB(add_name, sub_name, soft_t, host_t, \ > + host_abs_func, min_normal) \ > +static inline __attribute__((always_inline)) soft_t \ > +fpu_ ## soft_t

[Qemu-devel] [PATCH v1 08/14] hostfloat: support float32/64 addition and subtraction

2018-03-21 Thread Emilio G. Cota
Performance results (single and double precision) for fp-bench run under aarch64-linux-user on an Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz host: - before: add-single: 86.74 MFlops add-double: 86.46 MFlops sub-single: 83.33 MFlops sub-double: 84.57 MFlops - after: add-single: 188.26 MFlops add-dou