Re: [Qemu-devel] [PATCH v1 1/1] tcg: mips: Improve the add2/sub2 command to use TCG_TARGET_REG_BITS

2018-12-13 Thread Richard Henderson
On 12/12/18 2:58 PM, Alistair Francis wrote: > Instead of hard coding 31 for the shift right use > TCG_TARGET_REG_BITS - 1. > > Signed-off-by: Alistair Francis > --- > tcg/mips/tcg-target.inc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Queued. r~

Re: [Qemu-devel] [PATCH v1 1/1] tcg: mips: Improve the add2/sub2 command to use TCG_TARGET_REG_BITS

2018-12-12 Thread Richard Henderson
On 12/12/18 2:58 PM, Alistair Francis wrote: > Instead of hard coding 31 for the shift right use > TCG_TARGET_REG_BITS - 1. > > Signed-off-by: Alistair Francis > --- > tcg/mips/tcg-target.inc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v1 1/1] tcg: mips: Improve the add2/sub2 command to use TCG_TARGET_REG_BITS

2018-12-12 Thread Alistair Francis
Instead of hard coding 31 for the shift right use TCG_TARGET_REG_BITS - 1. Signed-off-by: Alistair Francis --- tcg/mips/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c index cff525373b..aa7cdabf23 100644