Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-19 Thread Alistair Francis
On Fri, Feb 19, 2016 at 9:15 AM, Andreas Färber wrote: > Am 18.02.2016 um 10:56 schrieb Markus Armbruster: >> Alistair Francis writes: >> >>> If the device being added when running qdev_device_add() has >>> a reset function, register it so that it can be called. >>> >>> Signed-off-by: Alistair Fr

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-19 Thread Paolo Bonzini
On 19/02/2016 11:55, Peter Maydell wrote: >> Any abstraction we have in QEMU should have at least a parallel (though >> > it need not be the same) in real hardware. Reset signals _do_ propagate >> > along buses, or at least along some buses, so "debusifying" reset seems >> > like a counterproduc

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-19 Thread Andreas Färber
Am 18.02.2016 um 10:56 schrieb Markus Armbruster: > Alistair Francis writes: > >> If the device being added when running qdev_device_add() has >> a reset function, register it so that it can be called. >> >> Signed-off-by: Alistair Francis >> --- >> >> qdev-monitor.c | 2 ++ >> 1 file changed,

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-19 Thread Peter Maydell
On 19 February 2016 at 09:33, Paolo Bonzini wrote: > Any abstraction we have in QEMU should have at least a parallel (though > it need not be the same) in real hardware. Reset signals _do_ propagate > along buses, or at least along some buses, so "debusifying" reset seems > like a counterproducti

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-19 Thread Markus Armbruster
Paolo Bonzini writes: > On 18/02/2016 10:56, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> If the device being added when running qdev_device_add() has >>> a reset function, register it so that it can be called. >>> >>> Signed-off-by: Alistair Francis >>> --- >>> >>> qdev-monito

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-19 Thread Paolo Bonzini
On 19/02/2016 00:07, Peter Crosthwaite wrote: > On Thu, Feb 18, 2016 at 1:47 PM, Paolo Bonzini wrote: >> >> >> On 18/02/2016 10:56, Markus Armbruster wrote: >>> Alistair Francis writes: >>> If the device being added when running qdev_device_add() has a reset function, register it so t

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-18 Thread Alistair Francis
On Thu, Feb 18, 2016 at 3:07 PM, Peter Crosthwaite wrote: > On Thu, Feb 18, 2016 at 1:47 PM, Paolo Bonzini wrote: >> >> >> On 18/02/2016 10:56, Markus Armbruster wrote: >>> Alistair Francis writes: >>> If the device being added when running qdev_device_add() has a reset function, regis

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-18 Thread Peter Crosthwaite
On Thu, Feb 18, 2016 at 1:47 PM, Paolo Bonzini wrote: > > > On 18/02/2016 10:56, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> If the device being added when running qdev_device_add() has >>> a reset function, register it so that it can be called. >>> >>> Signed-off-by: Alistair Fra

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-18 Thread Paolo Bonzini
On 18/02/2016 10:56, Markus Armbruster wrote: > Alistair Francis writes: > >> If the device being added when running qdev_device_add() has >> a reset function, register it so that it can be called. >> >> Signed-off-by: Alistair Francis >> --- >> >> qdev-monitor.c | 2 ++ >> 1 file changed, 2

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-18 Thread Alistair Francis
On Thu, Feb 18, 2016 at 1:56 AM, Markus Armbruster wrote: > Alistair Francis writes: > >> If the device being added when running qdev_device_add() has >> a reset function, register it so that it can be called. >> >> Signed-off-by: Alistair Francis >> --- >> >> qdev-monitor.c | 2 ++ >> 1 file c

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-18 Thread Markus Armbruster
Alistair Francis writes: > If the device being added when running qdev_device_add() has > a reset function, register it so that it can be called. > > Signed-off-by: Alistair Francis > --- > > qdev-monitor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/qdev-monitor.c b/qdev-monitor

[Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-17 Thread Alistair Francis
If the device being added when running qdev_device_add() has a reset function, register it so that it can be called. Signed-off-by: Alistair Francis --- qdev-monitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qdev-monitor.c b/qdev-monitor.c index 81e3ff3..0a99d01 100644 --- a/qdev-