Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-12 Thread Michael S. Tsirkin
On Wed, Feb 11, 2015 at 09:38:34AM +0800, Linhaifeng wrote: On 2015/2/10 20:04, Michael S. Tsirkin wrote: So that's not good. We need a way to negotiate the capability, we can't just deadlock with legacy slaves. Should we wait many seconds if slave not reply we just return error? I

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-11 Thread Linhaifeng
No.May be the existing slaves need add reply in their codes. So that's not good. We need a way to negotiate the capability, we can't just deadlock with legacy slaves. Hi,Michael Do you have any suggestions?

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Linhaifeng
On 2015/2/10 20:04, Michael S. Tsirkin wrote: So that's not good. We need a way to negotiate the capability, we can't just deadlock with legacy slaves. Should we wait many seconds if slave not reply we just return error? -- Regards, Haifeng

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Michael S. Tsirkin
On Tue, Feb 10, 2015 at 01:48:12PM +0800, linhaifeng wrote: From: Linhaifeng haifeng@huawei.com Slave should reply to master and set u64 to 0 if mmap all regions success otherwise set u64 to 1. Signed-off-by: Linhaifeng haifeng@huawei.com How does this work with existig slaves

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Michael S. Tsirkin
On Tue, Feb 10, 2015 at 06:27:04PM +0800, Linhaifeng wrote: On 2015/2/10 16:46, Michael S. Tsirkin wrote: On Tue, Feb 10, 2015 at 01:48:12PM +0800, linhaifeng wrote: From: Linhaifeng haifeng@huawei.com Slave should reply to master and set u64 to 0 if mmap all regions success

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Linhaifeng
On 2015/2/10 16:46, Michael S. Tsirkin wrote: On Tue, Feb 10, 2015 at 01:48:12PM +0800, linhaifeng wrote: From: Linhaifeng haifeng@huawei.com Slave should reply to master and set u64 to 0 if mmap all regions success otherwise set u64 to 1. Signed-off-by: Linhaifeng

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Linhaifeng
On 2015/2/10 18:41, Michael S. Tsirkin wrote: On Tue, Feb 10, 2015 at 06:27:04PM +0800, Linhaifeng wrote: On 2015/2/10 16:46, Michael S. Tsirkin wrote: On Tue, Feb 10, 2015 at 01:48:12PM +0800, linhaifeng wrote: From: Linhaifeng haifeng@huawei.com Slave should reply to master and set

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Michael S. Tsirkin
On Tue, Feb 10, 2015 at 07:59:16PM +0800, Linhaifeng wrote: On 2015/2/10 18:41, Michael S. Tsirkin wrote: On Tue, Feb 10, 2015 at 06:27:04PM +0800, Linhaifeng wrote: On 2015/2/10 16:46, Michael S. Tsirkin wrote: On Tue, Feb 10, 2015 at 01:48:12PM +0800, linhaifeng wrote: From:

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Linhaifeng
On 2015/2/10 20:04, Michael S. Tsirkin wrote: So that's not good. We need a way to negotiate the capability, we can't just deadlock with legacy slaves. Or add a new message to query slaves' version if slaves not reply we don't wait otherwise if the version as same as QEMU we wait the reply.

[Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-09 Thread linhaifeng
From: Linhaifeng haifeng@huawei.com Slave should reply to master and set u64 to 0 if mmap all regions success otherwise set u64 to 1. Signed-off-by: Linhaifeng haifeng@huawei.com --- docs/specs/vhost-user.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/specs/vhost-user.txt