[Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header

2015-07-27 Thread Alistair Francis
Pull the AHCI state structure out into the header. This allows other containers to access the struct. This is required to add the device to modern SoC containers. Signed-off-by: Alistair Francis Reviewed-by: Sai Pavan Boddu --- hw/ide/ahci.c | 13 - hw/ide/ahci.h | 14 ++

Re: [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header

2015-07-29 Thread John Snow
On 07/27/2015 02:37 PM, Alistair Francis wrote: > Pull the AHCI state structure out into the header. This allows > other containers to access the struct. This is required to add > the device to modern SoC containers. > Is there a reason this structure needs to be directly inlined into XlnxZynqM

Re: [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header

2015-07-29 Thread Alistair Francis
On Wed, Jul 29, 2015 at 3:21 PM, John Snow wrote: > > > On 07/27/2015 02:37 PM, Alistair Francis wrote: >> Pull the AHCI state structure out into the header. This allows >> other containers to access the struct. This is required to add >> the device to modern SoC containers. >> > > Is there a reas

Re: [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header

2015-08-15 Thread Peter Crosthwaite
On Wed, Jul 29, 2015 at 5:12 PM, Alistair Francis wrote: > On Wed, Jul 29, 2015 at 3:21 PM, John Snow wrote: >> >> >> On 07/27/2015 02:37 PM, Alistair Francis wrote: >>> Pull the AHCI state structure out into the header. This allows >>> other containers to access the struct. This is required to a

Re: [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header

2015-08-15 Thread Peter Crosthwaite
On Mon, Jul 27, 2015 at 11:37 AM, Alistair Francis wrote: > Pull the AHCI state structure out into the header. This allows > other containers to access the struct. This is required to add > the device to modern SoC containers. > > Signed-off-by: Alistair Francis > Reviewed-by: Sai Pavan Boddu >

Re: [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header

2015-08-15 Thread Peter Crosthwaite
On Sat, Aug 15, 2015 at 2:21 PM, Peter Crosthwaite wrote: > On Mon, Jul 27, 2015 at 11:37 AM, Alistair Francis > wrote: >> Pull the AHCI state structure out into the header. This allows >> other containers to access the struct. This is required to add >> the device to modern SoC containers. >> >>

Re: [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header

2015-08-15 Thread Peter Maydell
On 15 August 2015 at 22:18, Peter Crosthwaite wrote: > This has come up a few times, and the conclusion was to do the > inlining by preference. I vaguely remember PMM started an effort to > build infrastructure to hide the internals from use by outsiders, but > the struct def is desirable for the

Re: [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header

2015-08-18 Thread Alistair Francis
On Sat, Aug 15, 2015 at 2:25 PM, Peter Crosthwaite wrote: > On Sat, Aug 15, 2015 at 2:21 PM, Peter Crosthwaite > wrote: >> On Mon, Jul 27, 2015 at 11:37 AM, Alistair Francis >> wrote: >>> Pull the AHCI state structure out into the header. This allows >>> other containers to access the struct. Th