On 11/02/2015 11:42 PM, tu bo wrote:
> I agree with you. Adding more details as below,
> Replacing sed with awk, then it's easier to read.
Subjective opinion, but yes, I tend to agree that awk can be a pain to
learn when another tool can do the same job.
> Replacing "[ ! -z "$default_alias_machi
Hi Eric:
thanks for your review.
On 10/31/2015 01:36 AM, Eric Blake wrote:
On 10/30/2015 01:13 AM, Bo Tu wrote:
Be easier to read, and be slightly shorter.
You mentioned a very short "what" in the subject line (good), but the
"why" in the commit body ("easier to read, shorter") is rather ters
On 10/30/2015 01:13 AM, Bo Tu wrote:
> Be easier to read, and be slightly shorter.
You mentioned a very short "what" in the subject line (good), but the
"why" in the commit body ("easier to read, shorter") is rather terse and
subjective. It would be nicer to go into details (change the definition
Be easier to read, and be slightly shorter.
Suggested-By: Sascha Silbe
Reviewed-by: Sascha Silbe
Signed-off-by: Bo Tu
---
tests/qemu-iotests/common.config | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.con
