Re: [Qemu-devel] [PATCH v1 14/33] s390x/tcg: Implement VECTOR LOAD MULTIPLE

2019-02-28 Thread Richard Henderson
On 2/28/19 11:05 AM, David Hildenbrand wrote: > So for writing from helpers, I can use probe_write(). What about testing > write access from TCG code? > > I could do a load, followed by a store of the loaded value. This should > work in most cases (but eventually could be observed by somebody real

Re: [Qemu-devel] [PATCH v1 14/33] s390x/tcg: Implement VECTOR LOAD MULTIPLE

2019-02-28 Thread David Hildenbrand
On 28.02.19 18:15, Richard Henderson wrote: > On 2/28/19 12:36 AM, David Hildenbrand wrote: >> On 27.02.19 17:02, Richard Henderson wrote: >>> On 2/26/19 3:38 AM, David Hildenbrand wrote: Also fairly easy to implement. One issue we have is that exceptions will result in some vectors alrea

Re: [Qemu-devel] [PATCH v1 14/33] s390x/tcg: Implement VECTOR LOAD MULTIPLE

2019-02-28 Thread Richard Henderson
On 2/28/19 12:36 AM, David Hildenbrand wrote: > On 27.02.19 17:02, Richard Henderson wrote: >> On 2/26/19 3:38 AM, David Hildenbrand wrote: >>> Also fairly easy to implement. One issue we have is that exceptions will >>> result in some vectors already being modified. At least handle it >>> consiste

Re: [Qemu-devel] [PATCH v1 14/33] s390x/tcg: Implement VECTOR LOAD MULTIPLE

2019-02-28 Thread David Hildenbrand
On 27.02.19 17:02, Richard Henderson wrote: > On 2/26/19 3:38 AM, David Hildenbrand wrote: >> Also fairly easy to implement. One issue we have is that exceptions will >> result in some vectors already being modified. At least handle it >> consistently per vector by using a temporary vector. Good en

Re: [Qemu-devel] [PATCH v1 14/33] s390x/tcg: Implement VECTOR LOAD MULTIPLE

2019-02-27 Thread Richard Henderson
On 2/26/19 3:38 AM, David Hildenbrand wrote: > Also fairly easy to implement. One issue we have is that exceptions will > result in some vectors already being modified. At least handle it > consistently per vector by using a temporary vector. Good enough for > now, add a FIXME. > > Signed-off-by:

[Qemu-devel] [PATCH v1 14/33] s390x/tcg: Implement VECTOR LOAD MULTIPLE

2019-02-26 Thread David Hildenbrand
Also fairly easy to implement. One issue we have is that exceptions will result in some vectors already being modified. At least handle it consistently per vector by using a temporary vector. Good enough for now, add a FIXME. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def |