On 30 January 2014 08:00, Markus Armbruster wrote:
> Peter Maydell writes:
>> [MacOSX doesn't pull in common symbols from .o files in
>> .a archives]
> Not ugly, but a sensible move (in my opinion) regardless of this
> specific issue: compile with -fno-common. Then both become not common.
>
> `
Peter Maydell writes:
> On 15 January 2014 11:06, Peter Crosthwaite
> wrote:
>> This reverts commit d32934c84c72f57e78d430c22974677b7bcabe5d.
>>
>> The original implementation before this patch makes abortive error
>> messages much more friendly. The underlying bug that required this
>> change i
On 15 January 2014 11:06, Peter Crosthwaite
wrote:
> This reverts commit d32934c84c72f57e78d430c22974677b7bcabe5d.
>
> The original implementation before this patch makes abortive error
> messages much more friendly. The underlying bug that required this
> change is now fixed. Revert.
Unfortunate
Peter Crosthwaite writes:
> Ping!
>
> Do reverts require the usual reviewed-by? Markus are you happy with
> this mini series to address your error_report() concerns?
Yes, I'm happy with it. Thank you!
Hi,
I committed it last week, forgot to email you.
Cheers,
Edgar
On Tue, Jan 28, 2014 at 12:35:08PM +1000, Peter Crosthwaite wrote:
> Ping!
>
> Do reverts require the usual reviewed-by? Markus are you happy with
> this mini series to address your error_report() concerns?
>
> Regards,
> Peter
>
Ping!
Do reverts require the usual reviewed-by? Markus are you happy with
this mini series to address your error_report() concerns?
Regards,
Peter
On Wed, Jan 15, 2014 at 9:06 PM, Peter Crosthwaite
wrote:
> This reverts commit d32934c84c72f57e78d430c22974677b7bcabe5d.
>
> The original implement
This reverts commit d32934c84c72f57e78d430c22974677b7bcabe5d.
The original implementation before this patch makes abortive error
messages much more friendly. The underlying bug that required this
change is now fixed. Revert.
Signed-off-by: Peter Crosthwaite
---
util/error.c | 8
1 fil