Re: [Qemu-devel] [PATCH v1 2/4] hw/riscv/sifive_plic: Use gpios instead of irqs

2018-05-10 Thread Alistair Francis
On Wed, May 9, 2018 at 7:33 PM, Philippe Mathieu-Daudé wrote: > Hi Alistair, > > On 05/04/2018 05:13 PM, Alistair Francis wrote: >> Instead of creating the interrupt in lines with qemu_allocate_irq() use >> qdev_init_gpio_in() as this gives us the ability to use the qdev*gpio*() >> helpers later o

Re: [Qemu-devel] [PATCH v1 2/4] hw/riscv/sifive_plic: Use gpios instead of irqs

2018-05-09 Thread Philippe Mathieu-Daudé
Hi Alistair, On 05/04/2018 05:13 PM, Alistair Francis wrote: > Instead of creating the interrupt in lines with qemu_allocate_irq() use > qdev_init_gpio_in() as this gives us the ability to use the qdev*gpio*() > helpers later on. This is a good idea, but your patch is incomplete: The devices prev

[Qemu-devel] [PATCH v1 2/4] hw/riscv/sifive_plic: Use gpios instead of irqs

2018-05-04 Thread Alistair Francis
Instead of creating the interrupt in lines with qemu_allocate_irq() use qdev_init_gpio_in() as this gives us the ability to use the qdev*gpio*() helpers later on. Signed-off-by: Alistair Francis --- hw/riscv/sifive_plic.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw