Re: [Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables

2013-02-19 Thread Peter Crosthwaite
On Tue, Feb 19, 2013 at 4:12 AM, Peter Maydell wrote: > On 8 February 2013 04:03, Peter Crosthwaite > wrote: >> The DeviceState *mptimer var in a9mp_priv_state was only used by the init >> function and had no reason for persistence. Made a local variable and removed >> from state struct. > > Nope

Re: [Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables

2013-02-19 Thread Peter Crosthwaite
Hi Andreas, On Tue, Feb 19, 2013 at 7:56 PM, Andreas Färber wrote: > Am 19.02.2013 01:39, schrieb Peter Crosthwaite: >> On Tue, Feb 19, 2013 at 4:12 AM, Peter Maydell >> wrote: >>> On 8 February 2013 04:03, Peter Crosthwaite >>> wrote: The DeviceState *mptimer var in a9mp_priv_state was o

Re: [Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables

2013-02-19 Thread Peter Maydell
On 19 February 2013 12:43, Peter Crosthwaite wrote: > On Tue, Feb 19, 2013 at 7:56 PM, Andreas Färber wrote: >> The main point of concern being QMP. QOM realize has the purpose of >> decoupling device creation from device modification and emulation start. >> Thus devices may not be created in ini

Re: [Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables

2013-02-19 Thread Andreas Färber
Am 19.02.2013 01:39, schrieb Peter Crosthwaite: > On Tue, Feb 19, 2013 at 4:12 AM, Peter Maydell > wrote: >> On 8 February 2013 04:03, Peter Crosthwaite >> wrote: >>> The DeviceState *mptimer var in a9mp_priv_state was only used by the init >>> function and had no reason for persistence. Made a

Re: [Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables

2013-02-18 Thread Peter Crosthwaite
On Tue, Feb 19, 2013 at 4:12 AM, Peter Maydell wrote: > On 8 February 2013 04:03, Peter Crosthwaite > wrote: >> The DeviceState *mptimer var in a9mp_priv_state was only used by the init >> function and had no reason for persistence. Made a local variable and removed >> from state struct. > > Nope

Re: [Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables

2013-02-18 Thread Peter Maydell
On 8 February 2013 04:03, Peter Crosthwaite wrote: > The DeviceState *mptimer var in a9mp_priv_state was only used by the init > function and had no reason for persistence. Made a local variable and removed > from state struct. Nope. We're a container object, we can't just forget about our childr

[Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables

2013-02-07 Thread Peter Crosthwaite
The DeviceState *mptimer var in a9mp_priv_state was only used by the init function and had no reason for persistence. Made a local variable and removed from state struct. Signed-off-by: Peter Crosthwaite --- hw/a9mpcore.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff