Re: [Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operands initialization

2019-02-25 Thread Richard Henderson
On 2/25/19 3:55 AM, David Hildenbrand wrote: > Let's simply initialization to 0. > > Signed-off-by: David Hildenbrand > --- > target/s390x/translate.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) Modulo what ever fixed language you and Connie agree upon. ;-) Reviewed-by: Ric

Re: [Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operands initialization

2019-02-25 Thread David Hildenbrand
On 25.02.19 13:21, Cornelia Huck wrote: > On Mon, 25 Feb 2019 12:55:47 +0100 > David Hildenbrand wrote: > >> Let's simply initialization to 0. > > "Let's simply zero-initialize the structure." ? Or "s/simply/simplify/", whatever you prefer. > >> >> Signed-off-by: David Hildenbrand >> --- >>

Re: [Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operands initialization

2019-02-25 Thread Cornelia Huck
On Mon, 25 Feb 2019 12:55:47 +0100 David Hildenbrand wrote: > Let's simply initialization to 0. "Let's simply zero-initialize the structure." ? > > Signed-off-by: David Hildenbrand > --- > target/s390x/translate.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-)

Re: [Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operands initialization

2019-02-25 Thread Thomas Huth
On 25/02/2019 12.55, David Hildenbrand wrote: > Let's simply initialization to 0. > > Signed-off-by: David Hildenbrand > --- > target/s390x/translate.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/target/s390x/translate.c b/target/s390x/translate.c > index 190

[Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operands initialization

2019-02-25 Thread David Hildenbrand
Let's simply initialization to 0. Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 19072efec6..c646e50eb3 100644 --- a/target/s390x/translate.c +++ b/