Re: [Qemu-devel] [PATCH v1 3/3] virtio-balloon: Rework pbp tracking data

2019-07-22 Thread Michael S. Tsirkin
On Mon, Jul 22, 2019 at 09:43:43AM +0200, David Hildenbrand wrote: > On 22.07.19 05:04, David Gibson wrote: > > On Fri, Jul 19, 2019 at 06:01:20PM +0200, David Hildenbrand wrote: > >> Using the address of a RAMBlock to test for a matching pbp is not really > >> safe. Instead, let's use the guest ph

Re: [Qemu-devel] [PATCH v1 3/3] virtio-balloon: Rework pbp tracking data

2019-07-22 Thread David Hildenbrand
On 22.07.19 05:04, David Gibson wrote: > On Fri, Jul 19, 2019 at 06:01:20PM +0200, David Hildenbrand wrote: >> Using the address of a RAMBlock to test for a matching pbp is not really >> safe. Instead, let's use the guest physical address of the base page >> along with the page size (via the number

Re: [Qemu-devel] [PATCH v1 3/3] virtio-balloon: Rework pbp tracking data

2019-07-21 Thread David Gibson
On Fri, Jul 19, 2019 at 06:01:20PM +0200, David Hildenbrand wrote: > Using the address of a RAMBlock to test for a matching pbp is not really > safe. Instead, let's use the guest physical address of the base page > along with the page size (via the number of subpages). > > While at it, move "struc

[Qemu-devel] [PATCH v1 3/3] virtio-balloon: Rework pbp tracking data

2019-07-19 Thread David Hildenbrand
Using the address of a RAMBlock to test for a matching pbp is not really safe. Instead, let's use the guest physical address of the base page along with the page size (via the number of subpages). While at it, move "struct PartiallyBalloonedPage" to virtio-balloon.h now (previously most probably a