Re: [Qemu-devel] [PATCH v1 3/8] dmg: Limit the output buffer size to a max of 2MB

2017-04-27 Thread Ashijeet Acharya
On Thu, Apr 27, 2017 at 12:56 PM, Fam Zheng wrote: > On Wed, 04/26 17:30, John Snow wrote: >> Seems OK otherwise, but I would normally expect you to fix the buffering >> problems first, and then reduce the size of the buffer -- not the other >> way around. This version introduces

Re: [Qemu-devel] [PATCH v1 3/8] dmg: Limit the output buffer size to a max of 2MB

2017-04-27 Thread Fam Zheng
On Wed, 04/26 17:30, John Snow wrote: > Seems OK otherwise, but I would normally expect you to fix the buffering > problems first, and then reduce the size of the buffer -- not the other > way around. This version introduces new limitations that didn't exist > previously (As of this commit, QEMU

Re: [Qemu-devel] [PATCH v1 3/8] dmg: Limit the output buffer size to a max of 2MB

2017-04-27 Thread Ashijeet Acharya
On Thu, Apr 27, 2017 at 3:00 AM, John Snow wrote: > > > On 04/25/2017 03:59 PM, Ashijeet Acharya wrote: >> The size of the output buffer is limited to a maximum of 2MB so that >> QEMU doesn't end up allocating huge amounts of memory while >> decompressing compressed input

Re: [Qemu-devel] [PATCH v1 3/8] dmg: Limit the output buffer size to a max of 2MB

2017-04-26 Thread John Snow
On 04/25/2017 03:59 PM, Ashijeet Acharya wrote: > The size of the output buffer is limited to a maximum of 2MB so that > QEMU doesn't end up allocating huge amounts of memory while > decompressing compressed input streams. > > 2MB is an appropriate size because "qemu-img convert" has the same

[Qemu-devel] [PATCH v1 3/8] dmg: Limit the output buffer size to a max of 2MB

2017-04-25 Thread Ashijeet Acharya
The size of the output buffer is limited to a maximum of 2MB so that QEMU doesn't end up allocating huge amounts of memory while decompressing compressed input streams. 2MB is an appropriate size because "qemu-img convert" has the same I/O buffer size and the most important use case for DMG files