Re: [Qemu-devel] [PATCH v1 3/9] tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code

2019-08-23 Thread David Hildenbrand
On 23.08.19 17:22, Richard Henderson wrote: > On 8/23/19 3:07 AM, David Hildenbrand wrote: >> +void probe_write(CPUArchState *env, target_ulong addr, int size, int >> mmu_idx, >> + uintptr_t retaddr) >> +{ >> +CPUState *cpu = env_cpu(env); >> +CPUClass *cc; >> + >> +if

Re: [Qemu-devel] [PATCH v1 3/9] tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code

2019-08-23 Thread Richard Henderson
On 8/23/19 3:07 AM, David Hildenbrand wrote: > +void probe_write(CPUArchState *env, target_ulong addr, int size, int mmu_idx, > + uintptr_t retaddr) > +{ > +CPUState *cpu = env_cpu(env); > +CPUClass *cc; > + > +if (!guest_addr_valid(addr) || > +(size > 0 && !gues

Re: [Qemu-devel] [PATCH v1 3/9] tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code

2019-08-23 Thread Richard Henderson
On 8/23/19 3:07 AM, David Hildenbrand wrote: > Factor it out, we'll do some further changes/extensions to both > probe_write() implementations soon. Make sure to allow "size = 0". > > Signed-off-by: David Hildenbrand > --- > accel/tcg/user-exec.c | 16 > include/exec/exec-al

[Qemu-devel] [PATCH v1 3/9] tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code

2019-08-23 Thread David Hildenbrand
Factor it out, we'll do some further changes/extensions to both probe_write() implementations soon. Make sure to allow "size = 0". Signed-off-by: David Hildenbrand --- accel/tcg/user-exec.c | 16 include/exec/exec-all.h | 4 ++-- target/s390x/mem_helper.c | 7 --- 3