Re: [Qemu-devel] [PATCH v1 33/33] s390x/tcg: Implement VECTOR UNPACK *

2019-02-28 Thread David Hildenbrand
On 28.02.19 19:22, Richard Henderson wrote: > On 2/28/19 2:54 AM, David Hildenbrand wrote: >> Hmm, as v2 and v3 are handled concatenated it is not that easy. I am not >> sure if we can handle this without a temporary vector. >> >> I thought about packing them first interleaved >> >> v2 = [v2e0, v2e

Re: [Qemu-devel] [PATCH v1 33/33] s390x/tcg: Implement VECTOR UNPACK *

2019-02-28 Thread Richard Henderson
On 2/28/19 2:54 AM, David Hildenbrand wrote: > Hmm, as v2 and v3 are handled concatenated it is not that easy. I am not > sure if we can handle this without a temporary vector. > > I thought about packing them first interleaved > > v2 = [v2e0, v2e1] > v3 = [v3e0, ve31] > v1 = [v2e0_packed, v3e0_p

Re: [Qemu-devel] [PATCH v1 33/33] s390x/tcg: Implement VECTOR UNPACK *

2019-02-28 Thread David Hildenbrand
On 28.02.19 10:28, David Hildenbrand wrote: > On 28.02.19 01:03, Richard Henderson wrote: >> On 2/26/19 3:39 AM, David Hildenbrand wrote: >>> Combine all variant in a single handler. As source and destination >>> have different element sizes, we can't use gvec expansion. Expand >>> manually. Also w

Re: [Qemu-devel] [PATCH v1 33/33] s390x/tcg: Implement VECTOR UNPACK *

2019-02-28 Thread David Hildenbrand
On 28.02.19 01:03, Richard Henderson wrote: > On 2/26/19 3:39 AM, David Hildenbrand wrote: >> Combine all variant in a single handler. As source and destination >> have different element sizes, we can't use gvec expansion. Expand >> manually. Also watch out for overlapping source and destination an

Re: [Qemu-devel] [PATCH v1 33/33] s390x/tcg: Implement VECTOR UNPACK *

2019-02-27 Thread Richard Henderson
On 2/26/19 3:39 AM, David Hildenbrand wrote: > Combine all variant in a single handler. As source and destination > have different element sizes, we can't use gvec expansion. Expand > manually. Also watch out for overlapping source and destination and > use a temporary register in that case. > > S

[Qemu-devel] [PATCH v1 33/33] s390x/tcg: Implement VECTOR UNPACK *

2019-02-26 Thread David Hildenbrand
Combine all variant in a single handler. As source and destination have different element sizes, we can't use gvec expansion. Expand manually. Also watch out for overlapping source and destination and use a temporary register in that case. Signed-off-by: David Hildenbrand --- target/s390x/insn-d