Re: [Qemu-devel] [PATCH v1 6/6] Convert error_report*_err() to warn_report*_err()

2017-07-07 Thread Eduardo Habkost
On Thu, Jul 06, 2017 at 04:49:54PM -0700, Alistair Francis wrote: > Convert all uses of error_report*_err("[Ww]arning:"... to use > warn_report*_err() instead. This helps standardise on a single > method of printing warnings to the user. > > Signed-off-by: Alistair Francis > Cc: Paolo Bonzini >

Re: [Qemu-devel] [PATCH v1 6/6] Convert error_report*_err() to warn_report*_err()

2017-07-07 Thread Philippe Mathieu-Daudé
Hi Francis, On 07/06/2017 08:49 PM, Alistair Francis wrote: Convert all uses of error_report*_err("[Ww]arning:"... to use this is not the regex you used, maybe just use "Warning:"... warn_report*_err() instead. This helps standardise on a single standardize? "Enforce single method ..."?

[Qemu-devel] [PATCH v1 6/6] Convert error_report*_err() to warn_report*_err()

2017-07-06 Thread Alistair Francis
Convert all uses of error_report*_err("[Ww]arning:"... to use warn_report*_err() instead. This helps standardise on a single method of printing warnings to the user. Signed-off-by: Alistair Francis Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: "Michael S. Tsirkin" --- hw/c