Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2018-01-09 Thread Cornelia Huck
On Wed, 13 Dec 2017 10:31:58 +0100 David Hildenbrand wrote: > On 13.12.2017 10:16, Christian Borntraeger wrote: > > > > > > On 12/12/2017 04:28 PM, Cornelia Huck wrote: > >> On Tue, 12 Dec 2017 16:17:17 +0100 > >> David Hildenbrand wrote: > >> > >>> On 12.12.2017 15:29, Cornelia Huck wrote

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-13 Thread Christian Borntraeger
On 12/13/2017 10:31 AM, David Hildenbrand wrote: > On 13.12.2017 10:16, Christian Borntraeger wrote: >> >> >> On 12/12/2017 04:28 PM, Cornelia Huck wrote: >>> On Tue, 12 Dec 2017 16:17:17 +0100 >>> David Hildenbrand wrote: >>> On 12.12.2017 15:29, Cornelia Huck wrote: > On Tue, 12 Dec 2

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-13 Thread Cornelia Huck
On Wed, 13 Dec 2017 10:16:34 +0100 Christian Borntraeger wrote: > On 12/12/2017 04:28 PM, Cornelia Huck wrote: > > On Tue, 12 Dec 2017 16:17:17 +0100 > > David Hildenbrand wrote: > > > >> On 12.12.2017 15:29, Cornelia Huck wrote: > >>> On Tue, 12 Dec 2017 15:13:46 +0100 > >>> Christian Born

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-13 Thread David Hildenbrand
On 13.12.2017 10:16, Christian Borntraeger wrote: > > > On 12/12/2017 04:28 PM, Cornelia Huck wrote: >> On Tue, 12 Dec 2017 16:17:17 +0100 >> David Hildenbrand wrote: >> >>> On 12.12.2017 15:29, Cornelia Huck wrote: On Tue, 12 Dec 2017 15:13:46 +0100 Christian Borntraeger wrote:

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-13 Thread Christian Borntraeger
On 12/12/2017 04:28 PM, Cornelia Huck wrote: > On Tue, 12 Dec 2017 16:17:17 +0100 > David Hildenbrand wrote: > >> On 12.12.2017 15:29, Cornelia Huck wrote: >>> On Tue, 12 Dec 2017 15:13:46 +0100 >>> Christian Borntraeger wrote: >>> On 12/12/2017 02:49 PM, Cornelia Huck wrote: >>>

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-12 Thread David Hildenbrand
On 12.12.2017 14:49, Cornelia Huck wrote: > On Mon, 11 Dec 2017 14:47:31 +0100 > David Hildenbrand wrote: > >> Let the flic device handle it internally. This will allow us to later >> on store floating interrupts in the flic for the TCG case. >> >> This now also simplifies kvm.c. All that's left

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-12 Thread Cornelia Huck
On Tue, 12 Dec 2017 16:17:17 +0100 David Hildenbrand wrote: > On 12.12.2017 15:29, Cornelia Huck wrote: > > On Tue, 12 Dec 2017 15:13:46 +0100 > > Christian Borntraeger wrote: > > > >> On 12/12/2017 02:49 PM, Cornelia Huck wrote: > > > >>> One thing I noticed: You removed the caching of

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-12 Thread David Hildenbrand
On 12.12.2017 15:29, Cornelia Huck wrote: > On Tue, 12 Dec 2017 15:13:46 +0100 > Christian Borntraeger wrote: > >> On 12/12/2017 02:49 PM, Cornelia Huck wrote: > >>> One thing I noticed: You removed the caching of the flic (in the old >>> kvm inject routine), and you generally do more qom invoca

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-12 Thread Cornelia Huck
On Tue, 12 Dec 2017 15:13:46 +0100 Christian Borntraeger wrote: > On 12/12/2017 02:49 PM, Cornelia Huck wrote: > > One thing I noticed: You removed the caching of the flic (in the old > > kvm inject routine), and you generally do more qom invocations (first, > > to find the common flic; then, to

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-12 Thread Christian Borntraeger
On 12/12/2017 02:49 PM, Cornelia Huck wrote: > On Mon, 11 Dec 2017 14:47:31 +0100 > David Hildenbrand wrote: > >> Let the flic device handle it internally. This will allow us to later >> on store floating interrupts in the flic for the TCG case. >> >> This now also simplifies kvm.c. All that's

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-12 Thread Cornelia Huck
On Mon, 11 Dec 2017 14:47:31 +0100 David Hildenbrand wrote: > Let the flic device handle it internally. This will allow us to later > on store floating interrupts in the flic for the TCG case. > > This now also simplifies kvm.c. All that's left is the fallback > interface for floating interrupts

[Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-11 Thread David Hildenbrand
Let the flic device handle it internally. This will allow us to later on store floating interrupts in the flic for the TCG case. This now also simplifies kvm.c. All that's left is the fallback interface for floating interrupts, which is no triggered directly via the flic in case anything goes wron