Re: [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions

2017-11-29 Thread Richard Henderson
On 11/28/2017 08:33 PM, David Hildenbrand wrote: > TCG needs the retaddr when injecting an interrupt. Let's just pass it > along and use 0 for KVM. The value will be completely ignored for KVM. > > Convert program_interrupt() to program_interrupt_ra() directly, making > use of the passed address.

Re: [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions

2017-11-29 Thread David Hildenbrand
On 29.11.2017 16:57, Cornelia Huck wrote: > On Wed, 29 Nov 2017 16:45:21 +0100 > David Hildenbrand wrote: > >> On 29.11.2017 16:39, Cornelia Huck wrote: >>> On Wed, 29 Nov 2017 16:38:03 +0100 >>> David Hildenbrand wrote: >>> On 29.11.2017 16:35, Cornelia Huck wrote: > On Wed, 29 No

Re: [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions

2017-11-29 Thread Cornelia Huck
On Wed, 29 Nov 2017 16:45:21 +0100 David Hildenbrand wrote: > On 29.11.2017 16:39, Cornelia Huck wrote: > > On Wed, 29 Nov 2017 16:38:03 +0100 > > David Hildenbrand wrote: > > > >> On 29.11.2017 16:35, Cornelia Huck wrote: > >>> On Wed, 29 Nov 2017 16:14:40 +0100 > >>> David Hildenbrand wr

Re: [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions

2017-11-29 Thread David Hildenbrand
On 29.11.2017 16:39, Cornelia Huck wrote: > On Wed, 29 Nov 2017 16:38:03 +0100 > David Hildenbrand wrote: > >> On 29.11.2017 16:35, Cornelia Huck wrote: >>> On Wed, 29 Nov 2017 16:14:40 +0100 >>> David Hildenbrand wrote: >>> On 29.11.2017 16:13, Cornelia Huck wrote: > On Tue, 28 No

Re: [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions

2017-11-29 Thread David Hildenbrand
On 29.11.2017 16:35, Cornelia Huck wrote: > On Wed, 29 Nov 2017 16:14:40 +0100 > David Hildenbrand wrote: > >> On 29.11.2017 16:13, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 21:33:14 +0100 >>> David Hildenbrand wrote: >>> TCG needs the retaddr when injecting an interrupt. Let's just p

Re: [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions

2017-11-29 Thread Cornelia Huck
On Wed, 29 Nov 2017 16:14:40 +0100 David Hildenbrand wrote: > On 29.11.2017 16:13, Cornelia Huck wrote: > > On Tue, 28 Nov 2017 21:33:14 +0100 > > David Hildenbrand wrote: > > > >> TCG needs the retaddr when injecting an interrupt. Let's just pass it > >> along and use 0 for KVM. The value wi

Re: [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions

2017-11-29 Thread Cornelia Huck
On Wed, 29 Nov 2017 16:38:03 +0100 David Hildenbrand wrote: > On 29.11.2017 16:35, Cornelia Huck wrote: > > On Wed, 29 Nov 2017 16:14:40 +0100 > > David Hildenbrand wrote: > > > >> On 29.11.2017 16:13, Cornelia Huck wrote: > >>> On Tue, 28 Nov 2017 21:33:14 +0100 > >>> David Hildenbrand wr

Re: [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions

2017-11-29 Thread David Hildenbrand
On 29.11.2017 16:13, Cornelia Huck wrote: > On Tue, 28 Nov 2017 21:33:14 +0100 > David Hildenbrand wrote: > >> TCG needs the retaddr when injecting an interrupt. Let's just pass it >> along and use 0 for KVM. The value will be completely ignored for KVM. > > Can we get a #define for that? Just t

Re: [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions

2017-11-29 Thread Cornelia Huck
On Tue, 28 Nov 2017 21:33:14 +0100 David Hildenbrand wrote: > TCG needs the retaddr when injecting an interrupt. Let's just pass it > along and use 0 for KVM. The value will be completely ignored for KVM. Can we get a #define for that? Just to make it clear at a glance that we're passing an igno

[Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions

2017-11-28 Thread David Hildenbrand
TCG needs the retaddr when injecting an interrupt. Let's just pass it along and use 0 for KVM. The value will be completely ignored for KVM. Convert program_interrupt() to program_interrupt_ra() directly, making use of the passed address. Signed-off-by: David Hildenbrand --- target/s390x/intern