Re: [Qemu-devel] [PATCH v10 07/25] qapi-visit: Split off visit_type_FOO_fields forward decl

2015-10-23 Thread Eric Blake
On 10/23/2015 12:05 PM, Markus Armbruster wrote: def gen_visit_struct_fields(name, base, members): -struct_fields_seen.add(name) - ret = '' if base: ret += gen_visit_implicit_struct(base) +struct_fields_seen.add(name)

Re: [Qemu-devel] [PATCH v10 07/25] qapi-visit: Split off visit_type_FOO_fields forward decl

2015-10-23 Thread Markus Armbruster
Eric Blake writes: > On 10/23/2015 07:46 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> We generate a static visit_type_FOO_fields() for every type >>> FOO. However, sometimes we need a forward declaration. Split >>> the code to generate the forward declaration out of >>> gen_visit_

Re: [Qemu-devel] [PATCH v10 07/25] qapi-visit: Split off visit_type_FOO_fields forward decl

2015-10-23 Thread Eric Blake
On 10/23/2015 07:46 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We generate a static visit_type_FOO_fields() for every type >> FOO. However, sometimes we need a forward declaration. Split >> the code to generate the forward declaration out of >> gen_visit_implicit_struct() into a new

Re: [Qemu-devel] [PATCH v10 07/25] qapi-visit: Split off visit_type_FOO_fields forward decl

2015-10-23 Thread Markus Armbruster
Eric Blake writes: > We generate a static visit_type_FOO_fields() for every type > FOO. However, sometimes we need a forward declaration. Split > the code to generate the forward declaration out of > gen_visit_implicit_struct() into a new gen_visit_fields_decl(), > and also prepare for a forward

[Qemu-devel] [PATCH v10 07/25] qapi-visit: Split off visit_type_FOO_fields forward decl

2015-10-22 Thread Eric Blake
We generate a static visit_type_FOO_fields() for every type FOO. However, sometimes we need a forward declaration. Split the code to generate the forward declaration out of gen_visit_implicit_struct() into a new gen_visit_fields_decl(), and also prepare for a forward declaration to be emitted duri