Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread Peter Xu
On Mon, Jul 11, 2016 at 12:11:10PM +0300, David Kiarie wrote: > On Mon, Jul 11, 2016 at 10:41 AM, Peter Xu wrote: > > On Mon, Jul 11, 2016 at 10:16:11AM +0300, David Kiarie wrote: > >> On Mon, Jul 11, 2016 at 9:49 AM, Peter Xu wrote: > >> > On Mon, Jul 11, 2016 at 08:46:12AM +0300, David Kiarie w

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread David Kiarie
On Mon, Jul 11, 2016 at 10:41 AM, Peter Xu wrote: > On Mon, Jul 11, 2016 at 10:16:11AM +0300, David Kiarie wrote: >> On Mon, Jul 11, 2016 at 9:49 AM, Peter Xu wrote: >> > On Mon, Jul 11, 2016 at 08:46:12AM +0300, David Kiarie wrote: >> >> On Mon, Jul 11, 2016 at 8:32 AM, Peter Xu wrote: >> >> >

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread Peter Xu
On Mon, Jul 11, 2016 at 10:30:38AM +0200, Paolo Bonzini wrote: > > > On 11/07/2016 09:41, Peter Xu wrote: > > As mentioned in previous email, before Marcel's patches, > > vtd_host_dma_iommu() was named q35_host_dma_iommu(). At that time, I > > need "find_add_as" to let Q35 codes get rid of direct

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 09:41, Peter Xu wrote: > As mentioned in previous email, before Marcel's patches, > vtd_host_dma_iommu() was named q35_host_dma_iommu(). At that time, I > need "find_add_as" to let Q35 codes get rid of direct calls to VT-d > (so that pc_q35.c will not need to include "intel_iommu.h"

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread Peter Xu
On Mon, Jul 11, 2016 at 10:16:11AM +0300, David Kiarie wrote: > On Mon, Jul 11, 2016 at 9:49 AM, Peter Xu wrote: > > On Mon, Jul 11, 2016 at 08:46:12AM +0300, David Kiarie wrote: > >> On Mon, Jul 11, 2016 at 8:32 AM, Peter Xu wrote: > >> > On Sat, Jul 09, 2016 at 10:14:48AM +0200, Jan Kiszka wrot

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread David Kiarie
On Mon, Jul 11, 2016 at 9:49 AM, Peter Xu wrote: > On Mon, Jul 11, 2016 at 08:46:12AM +0300, David Kiarie wrote: >> On Mon, Jul 11, 2016 at 8:32 AM, Peter Xu wrote: >> > On Sat, Jul 09, 2016 at 10:14:48AM +0200, Jan Kiszka wrote: >> >> On 2016-07-05 10:19, Peter Xu wrote: >> >> > Remove VT-d call

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-10 Thread Peter Xu
On Mon, Jul 11, 2016 at 08:46:12AM +0300, David Kiarie wrote: > On Mon, Jul 11, 2016 at 8:32 AM, Peter Xu wrote: > > On Sat, Jul 09, 2016 at 10:14:48AM +0200, Jan Kiszka wrote: > >> On 2016-07-05 10:19, Peter Xu wrote: > >> > Remove VT-d calls in common q35 codes. Instead, we provide a general > >

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-10 Thread David Kiarie
On Mon, Jul 11, 2016 at 8:32 AM, Peter Xu wrote: > On Sat, Jul 09, 2016 at 10:14:48AM +0200, Jan Kiszka wrote: >> On 2016-07-05 10:19, Peter Xu wrote: >> > Remove VT-d calls in common q35 codes. Instead, we provide a general >> > find_add_as() for x86-iommu type. >> > >> > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-10 Thread Peter Xu
On Sat, Jul 09, 2016 at 10:14:48AM +0200, Jan Kiszka wrote: > On 2016-07-05 10:19, Peter Xu wrote: > > Remove VT-d calls in common q35 codes. Instead, we provide a general > > find_add_as() for x86-iommu type. > > > > Signed-off-by: Peter Xu > > --- > > hw/i386/intel_iommu.c | 15 +++

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-09 Thread Jan Kiszka
On 2016-07-05 10:19, Peter Xu wrote: > Remove VT-d calls in common q35 codes. Instead, we provide a general > find_add_as() for x86-iommu type. > > Signed-off-by: Peter Xu > --- > hw/i386/intel_iommu.c | 15 --- > include/hw/i386/intel_iommu.h | 5 - > include/hw/i386/x8

[Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-05 Thread Peter Xu
Remove VT-d calls in common q35 codes. Instead, we provide a general find_add_as() for x86-iommu type. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 15 --- include/hw/i386/intel_iommu.h | 5 - include/hw/i386/x86-iommu.h | 3 +++ 3 files changed, 11 insertions(