Re: [Qemu-devel] [PATCH v11 1/2] target/arm: Send interrupts on PMU counter overflow

2019-01-24 Thread Aaron Lindsay OS
On Jan 23 15:37, Richard Henderson wrote: > On 1/23/19 1:32 PM, Aaron Lindsay OS wrote: > > +uint64_t overflow_mask = env->cp15.c9_pmcr & PMCRLC ? \ > > + INT64_MIN : INT32_MIN; > > With type promotion, this is the same as writing > > ?

Re: [Qemu-devel] [PATCH v11 1/2] target/arm: Send interrupts on PMU counter overflow

2019-01-23 Thread Richard Henderson
On 1/23/19 1:32 PM, Aaron Lindsay OS wrote: > +uint64_t overflow_mask = env->cp15.c9_pmcr & PMCRLC ? \ > + INT64_MIN : INT32_MIN; With type promotion, this is the same as writing ? 0x8000ull : 0x8000ull which is probably not

[Qemu-devel] [PATCH v11 1/2] target/arm: Send interrupts on PMU counter overflow

2019-01-23 Thread Aaron Lindsay OS
Whenever we notice that a counter overflow has occurred, send an interrupt. This is made more reliable with the addition of a timer in a follow-on commit. Signed-off-by: Aaron Lindsay --- target/arm/helper.c | 61 + 1 file changed, 51 insertions(+),