Re: [Qemu-devel] [PATCH v11 13/28] qapi: Hoist tag collision check to Variants.check()

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > On 11/11/2015 06:56 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Checking that a given QAPISchemaObjectTypeVariant.name is a >>> member of the corresponding QAPISchemaEnumType of the owning >>>

Re: [Qemu-devel] [PATCH v11 13/28] qapi: Hoist tag collision check to Variants.check()

2015-11-11 Thread Eric Blake
On 11/11/2015 06:56 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Checking that a given QAPISchemaObjectTypeVariant.name is a >> member of the corresponding QAPISchemaEnumType of the owning >> QAPISchemaObjectTypeVariants.tag_member ensures that there are >> no

Re: [Qemu-devel] [PATCH v11 13/28] qapi: Hoist tag collision check to Variants.check()

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > Checking that a given QAPISchemaObjectTypeVariant.name is a > member of the corresponding QAPISchemaEnumType of the owning > QAPISchemaObjectTypeVariants.tag_member ensures that there are > no collisions in the generated C union for those tag values >

[Qemu-devel] [PATCH v11 13/28] qapi: Hoist tag collision check to Variants.check()

2015-11-10 Thread Eric Blake
Checking that a given QAPISchemaObjectTypeVariant.name is a member of the corresponding QAPISchemaEnumType of the owning QAPISchemaObjectTypeVariants.tag_member ensures that there are no collisions in the generated C union for those tag values (since the enum itself should have no collisions).