Andreas, thanks for your review.
The issue is we were developing this device using other devices code
(mainly e1000 and virtio-net) as a reference, and unfortunately they don't
follow current QOM rules.
Also these patches are pretty long-living (around a year already), I'm not
sure what was the pr
On Mon, Feb 25, 2013 at 11:05:31PM +0100, Andreas Färber wrote:
> > +
> > +static void vmxnet3_qdev_reset(DeviceState *dev)
> > +{
> > +VMXNET3State *s = DO_UPCAST(VMXNET3State, dev.qdev, dev);
>
> Cast macro
>
> Stefan, please keep an eye on such QOM issues during your review!
I'll try but
Am 25.02.2013 21:11, schrieb Dmitry Fleytman:
[snip]
> +static int
> +vmxnet3_msix_load(QEMUFile *f, void *opaque, int version_id)
> +{
> +msix_load(&((VMXNET3State *)opaque)->dev, f);
Apart from doing too much in one line, you should not access the parent
field ->dev directly but use PCI_DEVI
