Re: [Qemu-devel] [PATCH v12 06/17] block: Add bitmap successors

2015-02-11 Thread John Snow
On 02/11/2015 11:50 AM, Max Reitz wrote: With the full stops and newlines removed (in all error_setg() calls in this patch): Habits, habits, habits.\n Thanks.\n

Re: [Qemu-devel] [PATCH v12 06/17] block: Add bitmap successors

2015-02-11 Thread Max Reitz
On 2015-02-09 at 20:35, John Snow wrote: A bitmap successor is an anonymous BdrvDirtyBitmap that is intended to be created just prior to a sensitive operation (e.g. Incremental Backup) that can either succeed or fail, but during the course of which we still want a bitmap tracking writes. On crea

[Qemu-devel] [PATCH v12 06/17] block: Add bitmap successors

2015-02-09 Thread John Snow
A bitmap successor is an anonymous BdrvDirtyBitmap that is intended to be created just prior to a sensitive operation (e.g. Incremental Backup) that can either succeed or fail, but during the course of which we still want a bitmap tracking writes. On creating a successor, we "freeze" the parent bi