On Thu, Sep 04, 2014 at 05:23:21PM +0200, Kevin Wolf wrote:
> The definition of "besteffort" depends on what you want to achieve. It
> is policy, and we generally try to keep policy out of qemu.
I think qemu *should* have a policy of make it work and don't fail - first -
and then offer a million k
Am 04.09.2014 um 15:43 hat Richard W.M. Jones geschrieben:
> On Thu, Sep 04, 2014 at 03:17:51PM +0200, Kevin Wolf wrote:
> > Am 04.09.2014 um 15:07 hat Richard W.M. Jones geschrieben:
> > > On Thu, Sep 04, 2014 at 02:52:57PM +0200, Kevin Wolf wrote:
> > > > Am 04.09.2014 um 14:45 hat Richard W.M. J
On Thu, Sep 04, 2014 at 03:17:51PM +0200, Kevin Wolf wrote:
> Am 04.09.2014 um 15:07 hat Richard W.M. Jones geschrieben:
> > On Thu, Sep 04, 2014 at 02:52:57PM +0200, Kevin Wolf wrote:
> > > Am 04.09.2014 um 14:45 hat Richard W.M. Jones geschrieben:
> > > > On Thu, Sep 04, 2014 at 02:35:22PM +0200,
Am 04.09.2014 um 15:07 hat Richard W.M. Jones geschrieben:
> On Thu, Sep 04, 2014 at 02:52:57PM +0200, Kevin Wolf wrote:
> > Am 04.09.2014 um 14:45 hat Richard W.M. Jones geschrieben:
> > > On Thu, Sep 04, 2014 at 02:35:22PM +0200, Kevin Wolf wrote:
> > > > Please change the code to always write ze
On Thu, Sep 04, 2014 at 02:07:14PM +0100, Richard W.M. Jones wrote:
> On Thu, Sep 04, 2014 at 02:52:57PM +0200, Kevin Wolf wrote:
> > Am 04.09.2014 um 14:45 hat Richard W.M. Jones geschrieben:
> > > On Thu, Sep 04, 2014 at 02:35:22PM +0200, Kevin Wolf wrote:
> > > > Please change the code to always
On Thu, Sep 04, 2014 at 02:52:57PM +0200, Kevin Wolf wrote:
> Am 04.09.2014 um 14:45 hat Richard W.M. Jones geschrieben:
> > On Thu, Sep 04, 2014 at 02:35:22PM +0200, Kevin Wolf wrote:
> > > Please change the code to always write zeros for FULL,
> >
> > How is this useful for anyone? You don't kn
Am 04.09.2014 um 14:45 hat Richard W.M. Jones geschrieben:
> On Thu, Sep 04, 2014 at 02:35:22PM +0200, Kevin Wolf wrote:
> > Please change the code to always write zeros for FULL,
>
> How is this useful for anyone? You don't know if the underlying SAN
> is going to detect these zeroes or combine
On Thu, Sep 04, 2014 at 02:35:22PM +0200, Kevin Wolf wrote:
> Please change the code to always write zeros for FULL,
How is this useful for anyone? You don't know if the underlying SAN
is going to detect these zeroes or combine these blocks together.
It's just slow for no reason.
Rich.
--
Rich
Am 29.08.2014 um 10:33 hat Hu Tao geschrieben:
> This patch adds a new option preallocation for raw format, and implements
> full preallocation.
>
> Signed-off-by: Hu Tao
v12 was better, it wasn't doing only metadata preallocation when you
told it to do full preallocation.
> +if (prealloc =
On Fri, Aug 29, 2014 at 09:48:01AM +0100, Richard W.M. Jones wrote:
> On Fri, Aug 29, 2014 at 04:33:12PM +0800, Hu Tao wrote:
> > +if (prealloc == PREALLOC_MODE_FULL) {
> > +/* posix_fallocate() doesn't set errno. */
> > +result = -posix_fallocate(fd, 0, total_size);
> > +
On Tue, Sep 02, 2014 at 11:45:38PM +0200, Max Reitz wrote:
> On 29.08.2014 10:33, Hu Tao wrote:
> >This patch adds a new option preallocation for raw format, and implements
> >full preallocation.
> >
> >Signed-off-by: Hu Tao
> >---
> > block/raw-posix.c | 92
> > +
On Fri, Aug 29, 2014 at 09:48:01AM +0100, Richard W.M. Jones wrote:
> On Fri, Aug 29, 2014 at 04:33:12PM +0800, Hu Tao wrote:
> > +if (prealloc == PREALLOC_MODE_FULL) {
> > +/* posix_fallocate() doesn't set errno. */
> > +result = -posix_fallocate(fd, 0, total_size);
> > +
On 29.08.2014 10:33, Hu Tao wrote:
This patch adds a new option preallocation for raw format, and implements
full preallocation.
Signed-off-by: Hu Tao
---
block/raw-posix.c | 92 +++
qemu-doc.texi | 8 +
qemu-img.texi | 8 +++
On Fri, Aug 29, 2014 at 04:33:12PM +0800, Hu Tao wrote:
> +if (prealloc == PREALLOC_MODE_FULL) {
> +/* posix_fallocate() doesn't set errno. */
> +result = -posix_fallocate(fd, 0, total_size);
> +if (result != 0) {
Is it better to test:
result != ENOSYS && result != E
This patch adds a new option preallocation for raw format, and implements
full preallocation.
Signed-off-by: Hu Tao
---
block/raw-posix.c | 92 +++
qemu-doc.texi | 8 +
qemu-img.texi | 8 +
3 files changed, 88 insertions(+), 2
15 matches
Mail list logo
