Re: [Qemu-devel] [PATCH v14 01/19] qapi: Consolidate object visitors

2016-04-15 Thread Markus Armbruster
Eric Blake writes: > On 04/13/2016 06:48 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Rather than having two separate visitor callbacks with items >>> already broken out, pass the actual QAPISchemaObjectType object >>> to the visitor. This lets the visitor access things like >>> t

Re: [Qemu-devel] [PATCH v14 01/19] qapi: Consolidate object visitors

2016-04-13 Thread Eric Blake
On 04/13/2016 06:48 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Rather than having two separate visitor callbacks with items >> already broken out, pass the actual QAPISchemaObjectType object >> to the visitor. This lets the visitor access things like >> type.is_implicit() without nee

Re: [Qemu-devel] [PATCH v14 01/19] qapi: Consolidate object visitors

2016-04-13 Thread Markus Armbruster
Eric Blake writes: > Rather than having two separate visitor callbacks with items > already broken out, pass the actual QAPISchemaObjectType object > to the visitor. This lets the visitor access things like > type.is_implicit() without needing another parameter, resolving > a TODO from previous

[Qemu-devel] [PATCH v14 01/19] qapi: Consolidate object visitors

2016-04-08 Thread Eric Blake
Rather than having two separate visitor callbacks with items already broken out, pass the actual QAPISchemaObjectType object to the visitor. This lets the visitor access things like type.is_implicit() without needing another parameter, resolving a TODO from previous patches. For convenience and c