Re: [Qemu-devel] [PATCH v14 01/21] option: make parse_option_bool/number non-static

2016-10-21 Thread Markus Armbruster
Eric Blake writes: > On 10/21/2016 11:55 AM, Markus Armbruster wrote: > >> >> On first glance, this patch makes the boolean values recognized on the >> command line consistent regardless of which part of the code is used to >> recognize them, by extending the QemuOpts parser to accept the option

Re: [Qemu-devel] [PATCH v14 01/21] option: make parse_option_bool/number non-static

2016-10-21 Thread Eric Blake
On 10/21/2016 11:55 AM, Markus Armbruster wrote: > > On first glance, this patch makes the boolean values recognized on the > command line consistent regardless of which part of the code is used to > recognize them, by extending the QemuOpts parser to accept the option > visitor's additional conv

Re: [Qemu-devel] [PATCH v14 01/21] option: make parse_option_bool/number non-static

2016-10-21 Thread Markus Armbruster
"Daniel P. Berrange" writes: > The opts-visitor.c opts_type_bool() method has code for > parsing a string to set a bool value, as does the > qemu-option.c parse_option_bool() method, except it > handles fewer cases. > > To enable consistency across the codebase, extend > parse_option_bool() to ha

[Qemu-devel] [PATCH v14 01/21] option: make parse_option_bool/number non-static

2016-09-30 Thread Daniel P. Berrange
The opts-visitor.c opts_type_bool() method has code for parsing a string to set a bool value, as does the qemu-option.c parse_option_bool() method, except it handles fewer cases. To enable consistency across the codebase, extend parse_option_bool() to handle "yes", "no", "y" and "n", and make it n