Re: [Qemu-devel] [PATCH v14 03/19] qapi: Guarantee NULL obj on input visitor callback error

2016-04-13 Thread Markus Armbruster
Eric Blake writes: > Our existing input visitors were not very consistent on errors > in a function taking 'TYPE **obj'. While all of them set '*obj' Suggest to list the methods. I guess it's start_struct(), start_alternate(), type_str(), type_any(). > to allocated storage on success, it was n

[Qemu-devel] [PATCH v14 03/19] qapi: Guarantee NULL obj on input visitor callback error

2016-04-08 Thread Eric Blake
Our existing input visitors were not very consistent on errors in a function taking 'TYPE **obj'. While all of them set '*obj' to allocated storage on success, it was not obvious whether '*obj' was guaranteed safe on failure, or whether it was left uninitialized. But a future patch wants to guaran