Re: [Qemu-devel] [PATCH v14 04/13] Add cache handling functions

2012-07-04 Thread Orit Wasserman
On 07/03/2012 10:49 PM, Eric Blake wrote: > On 07/03/2012 01:23 PM, Blue Swirl wrote: > >>> + >>> +static inline int64_t round2pow2(int64_t value) > > round up or down? > >>> +{ >>> +while (!is_power_of_2(value)) { >>> +value &= ~(1 << (ffs(value) - 1)); >> >> ffs() only uses 'int',

Re: [Qemu-devel] [PATCH v14 04/13] Add cache handling functions

2012-07-03 Thread Eric Blake
On 07/03/2012 07:52 AM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > +PageCache *cache_init(int64_t num_pages, un

Re: [Qemu-devel] [PATCH v14 04/13] Add cache handling functions

2012-07-03 Thread Eric Blake
On 07/03/2012 01:23 PM, Blue Swirl wrote: >> + >> +static inline int64_t round2pow2(int64_t value) round up or down? >> +{ >> +while (!is_power_of_2(value)) { >> +value &= ~(1 << (ffs(value) - 1)); > > ffs() only uses 'int', not int64_t. ffsl() is not universally available. > >>

Re: [Qemu-devel] [PATCH v14 04/13] Add cache handling functions

2012-07-03 Thread Blue Swirl
On Tue, Jul 3, 2012 at 1:52 PM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- > Makefile.objs |

[Qemu-devel] [PATCH v14 04/13] Add cache handling functions

2012-07-03 Thread Orit Wasserman
Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- Makefile.objs |1 + include/qemu/page_cache.h | 79 + page_cache.c