Re: [Qemu-devel] [PATCH v14 18/19] qapi: Simplify semantics of visit_next_list()

2016-04-27 Thread Eric Blake
On 04/22/2016 05:35 AM, Markus Armbruster wrote: static void -start_list(Visitor *v, const char *name, Error **errp) +start_list(Visitor *v, const char *name, GenericList **list, size_t size, + +parse_str(siv, &err); +if (err) { +*list = NU

Re: [Qemu-devel] [PATCH v14 18/19] qapi: Simplify semantics of visit_next_list()

2016-04-22 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster writes: > > [...] >>> diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c >>> index 797973a..77dd1a7 100644 >>> --- a/qapi/string-input-visitor.c >>> +++ b/qapi/string-input-visitor.c >>> @@ -25,8 +25,6 @@ struct StringInputVisitor

Re: [Qemu-devel] [PATCH v14 18/19] qapi: Simplify semantics of visit_next_list()

2016-04-22 Thread Markus Armbruster
Markus Armbruster writes: [...] >> diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c >> index 797973a..77dd1a7 100644 >> --- a/qapi/string-input-visitor.c >> +++ b/qapi/string-input-visitor.c >> @@ -25,8 +25,6 @@ struct StringInputVisitor >> { >> Visitor visitor; >> >>

Re: [Qemu-devel] [PATCH v14 18/19] qapi: Simplify semantics of visit_next_list()

2016-04-15 Thread Markus Armbruster
Eric Blake writes: > We have two uses of list visits in the entire code base: one in > spapr_drc (which completely avoids visit_next_list(), feeding in > integers from a different source than uint8List), and one in > qapi-visit.py Period here, convert the parenthesis to a sentence. >

[Qemu-devel] [PATCH v14 18/19] qapi: Simplify semantics of visit_next_list()

2016-04-08 Thread Eric Blake
We have two uses of list visits in the entire code base: one in spapr_drc (which completely avoids visit_next_list(), feeding in integers from a different source than uint8List), and one in qapi-visit.py (that is, all other list visitors are generated in qapi-visit.c, and share the same paradigm ba