Re: [Qemu-devel] [PATCH v14 27/33] target-tilegx: Handle mask instructions

2015-08-31 Thread Richard Henderson
On 08/30/2015 06:52 AM, Peter Maydell wrote: I *think* this code is correct, but the ISA manual perplexes me entirely. Why on earth would you describe anything as "compute the boolean AND of something with a value of all ones", when that's just a no-op? I can't see what I'm missing that means the

Re: [Qemu-devel] [PATCH v14 27/33] target-tilegx: Handle mask instructions

2015-08-30 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target-tilegx/translate.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c > index 51ee158..af4b34a 100644 > -

[Qemu-devel] [PATCH v14 27/33] target-tilegx: Handle mask instructions

2015-08-24 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 51ee158..af4b34a 100644 --- a/target-tilegx/translate.c +++ b/target-tilegx/translate.c @@ -64