Re: [Qemu-devel] [PATCH v14 29/33] target-tilegx: Handle mtspr, mfspr

2015-08-31 Thread Richard Henderson
On 08/30/2015 08:18 AM, Peter Maydell wrote: +static const TileSPR *find_spr(unsigned spr) +{ +/* Allow the compiler to construct the binary search tree. */ This feels a bit overly clever to me but if we only have three registers anyway it doesn't matter much. I was just forward looking

Re: [Qemu-devel] [PATCH v14 29/33] target-tilegx: Handle mtspr, mfspr

2015-08-30 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target-tilegx/translate.c | 76 > +-- > 1 file changed, 73 insertions(+), 3 deletions(-) > > diff --git a/target-tilegx/translate.c b/target-tilegx/transla

[Qemu-devel] [PATCH v14 29/33] target-tilegx: Handle mtspr, mfspr

2015-08-24 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 76 +-- 1 file changed, 73 insertions(+), 3 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 1224a8e..210e912 100644 --- a/target-tilegx/translate.c +