Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments

2016-04-28 Thread Eric Blake
On 04/28/2016 12:00 PM, Markus Armbruster wrote: >>> Have you checked Marc-André's work for overlap? Cc'ing him. >> >> yeah, it's conflicting with my work. Unfortunately, since I have been >> asked to wait since a long time, I am no longer on top of things, nor >> what I need to wait for. I have t

Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments

2016-04-28 Thread Markus Armbruster
Marc-André Lureau writes: > On Thu, Apr 28, 2016 at 4:09 PM, Markus Armbruster wrote: >> >> * device_add, qmp_capabilities >> >> Not QAPIfied, need everything. > > Some related commits from https://github.com/elmarco/qemu/commits/qapi > > > https://github.com/elmarco/qemu/commit/e6828a0a926e20

Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments

2016-04-28 Thread Eric Blake
On 04/28/2016 08:09 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Having to manually call out the set of expected arguments in >> qmp-commands.hx, in addition to what is already in *.json, >> is tedious and prone to error. The only reason we use >> .args_type is for checking if there is

Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments

2016-04-28 Thread Marc-André Lureau
On Thu, Apr 28, 2016 at 4:09 PM, Markus Armbruster wrote: > > * device_add, qmp_capabilities > > Not QAPIfied, need everything. Some related commits from https://github.com/elmarco/qemu/commits/qapi https://github.com/elmarco/qemu/commit/e6828a0a926e20d3ee91ea956152b610ca30d2b8 https://githu

Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments

2016-04-28 Thread Markus Armbruster
Eric Blake writes: > Having to manually call out the set of expected arguments in > qmp-commands.hx, in addition to what is already in *.json, > is tedious and prone to error. The only reason we use > .args_type is for checking if there is any excess arguments > or incorrectly typed arguments du

[Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments

2016-04-27 Thread Eric Blake
Having to manually call out the set of expected arguments in qmp-commands.hx, in addition to what is already in *.json, is tedious and prone to error. The only reason we use .args_type is for checking if there is any excess arguments or incorrectly typed arguments during qmp_check_client_args(), b