Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-15 Thread Halil Pasic
On 02/13/2017 02:41 PM, Stefan Hajnoczi wrote: > On Fri, Feb 03, 2017 at 07:07:02PM +0100, Halil Pasic wrote: >> >> >> On 02/03/2017 04:37 PM, Michael S. Tsirkin wrote: >>> On Fri, Feb 03, 2017 at 10:33:16AM +, Stefan Hajnoczi wrote: > +\begin{description} > +\item[0] dataq1 > +\i

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-13 Thread Stefan Hajnoczi
On Fri, Feb 03, 2017 at 07:07:02PM +0100, Halil Pasic wrote: > > > On 02/03/2017 04:37 PM, Michael S. Tsirkin wrote: > > On Fri, Feb 03, 2017 at 10:33:16AM +, Stefan Hajnoczi wrote: > >>> +\begin{description} > >>> +\item[0] dataq1 > >>> +\item[\ldots] > >>> +\item[N-1] dataqN > >>> +\item[N]

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-08 Thread Gonglei (Arei)
> > On 02/07/2017 01:59 AM, Gonglei (Arei) wrote: > > Hi, > > > >> From: Michael S. Tsirkin [mailto:m...@redhat.com] > >> Sent: Tuesday, February 07, 2017 2:20 AM > >> Subject: Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto >

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-08 Thread Halil Pasic
On 02/07/2017 01:59 AM, Gonglei (Arei) wrote: > Hi, > >> From: Michael S. Tsirkin [mailto:m...@redhat.com] >> Sent: Tuesday, February 07, 2017 2:20 AM >> Subject: Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto >> device specification >> &

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-07 Thread Halil Pasic
On 02/06/2017 07:19 PM, Michael S. Tsirkin wrote: > On Mon, Feb 06, 2017 at 03:46:25PM +, Stefan Hajnoczi wrote: >> On Mon, Feb 06, 2017 at 01:48:09AM +, Gonglei (Arei) wrote: > +\item The device MUST set \field{max_size} to show the maximum size of crypto request the device supp

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-06 Thread Gonglei (Arei)
Hi, > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, February 07, 2017 2:20 AM > Subject: Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto > device specification > > On Mon, Feb 06, 2017 at 03:46:25PM +, Stefan Hajnoczi wrote: > >

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-06 Thread Michael S. Tsirkin
On Mon, Feb 06, 2017 at 03:46:25PM +, Stefan Hajnoczi wrote: > On Mon, Feb 06, 2017 at 01:48:09AM +, Gonglei (Arei) wrote: > > > > +\item The device MUST set \field{max_size} to show the maximum size of > > > crypto request the device supports. > > > > > > In bytes? > > > > > > > +\item T

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-06 Thread Stefan Hajnoczi
On Mon, Feb 06, 2017 at 01:48:09AM +, Gonglei (Arei) wrote: > > > +\item The device MUST set \field{max_size} to show the maximum size of > > crypto request the device supports. > > > > In bytes? > > > > > +\item The device MUST set \field{max_cipher_key_len} to show the > > maximum length of

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-05 Thread Gonglei (Arei)
Hi Stefan, I'm just back from Chinese New year's holiday. > > Subject: Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto > device specification > > On Wed, Jan 18, 2017 at 04:22:36PM +0800, Gonglei wrote: > > The virtio crypto device is a virt

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-03 Thread Halil Pasic
On 02/03/2017 04:37 PM, Michael S. Tsirkin wrote: > On Fri, Feb 03, 2017 at 10:33:16AM +, Stefan Hajnoczi wrote: >>> +\begin{description} >>> +\item[0] dataq1 >>> +\item[\ldots] >>> +\item[N-1] dataqN >>> +\item[N] controlq >>> +\end{description} >>> + >>> +N is set by \field{max_dataqueues}.

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-03 Thread Michael S. Tsirkin
On Fri, Feb 03, 2017 at 10:33:16AM +, Stefan Hajnoczi wrote: > > +\begin{description} > > +\item[0] dataq1 > > +\item[\ldots] > > +\item[N-1] dataqN > > +\item[N] controlq > > +\end{description} > > + > > +N is set by \field{max_dataqueues}. > > + > > +\subsection{Feature bits}\label{sec:Device

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-03 Thread Stefan Hajnoczi
On Wed, Jan 18, 2017 at 04:22:36PM +0800, Gonglei wrote: > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). Currently, the virtio crypto device provides > the following crypto services: CIPHER, MAC, HASH, and AEAD. > > In this patch, CIPHER, MAC, HASH,

[Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-01-18 Thread Gonglei
The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). Currently, the virtio crypto device provides the following crypto services: CIPHER, MAC, HASH, and AEAD. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. VIRTIO-153 Signed-off-by: Gonglei