Re: [Qemu-devel] [PATCH v2][Outreachy Round 12]

2016-03-06 Thread Sarah Khan
Thank you for your feedback. Will do the required. Sorry for the delay as I was out of station. Thanks, Sarah On Sat, Mar 5, 2016 at 4:12 PM, Markus Armbruster wrote: > Your commit message isn't quite right, yet. The first line is empty, > which leads to > > Subject: [PATCH v2][Outreachy

Re: [Qemu-devel] [PATCH v2][Outreachy Round 12]

2016-03-05 Thread Markus Armbruster
Your commit message isn't quite right, yet. The first line is empty, which leads to Subject: [PATCH v2][Outreachy Round 12] in e-mail, which isn't really useful. It should be a line of the form subsystem: Headline describing the patch briefly In e-mail, this becomes something like

[Qemu-devel] [PATCH v2][Outreachy Round 12]

2016-03-04 Thread Sarah Khan
Replaced g_malloc() with g_new() as it would detect multiplication overflow if nb_fields ever oversize. There is no corresponding free(). thunk_register_struct() is called only at startup from the linux-user code in order to populate the struct_entries array; this data structure then remains live