[Qemu-devel] [PATCH v2] MSI: Robust resource release

2011-05-02 Thread Jan Kiszka
msi_init may fail, so we need to check on uninit if the cap was actually installed. This also avoids that the users need to check. Signed-off-by: Jan Kiszka --- hw/ide/ich.c |5 + hw/intel-hda.c |4 +--- hw/msi.c | 12 ++-- 3 files changed, 12 insertions(+), 9 delet

Re: [Qemu-devel] [PATCH v2] MSI: Robust resource release

2011-05-03 Thread Alexander Graf
On 02.05.2011, at 20:00, Jan Kiszka wrote: > msi_init may fail, so we need to check on uninit if the cap was > actually installed. This also avoids that the users need to check. > > Signed-off-by: Jan Kiszka Looks good to me. Acked-by: Alexander Graf Alex

Re: [Qemu-devel] [PATCH v2] MSI: Robust resource release

2011-05-05 Thread Michael S. Tsirkin
On Mon, May 02, 2011 at 08:00:47PM +0200, Jan Kiszka wrote: > msi_init may fail, so we need to check on uninit if the cap was > actually installed. This also avoids that the users need to check. > > Signed-off-by: Jan Kiszka Applied, thanks! > --- > hw/ide/ich.c |5 + > hw/intel-hda.