Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

2016-03-02 Thread Peter Maydell
On 2 March 2016 at 17:13, Programmingkid wrote: > > On Mar 2, 2016, at 11:45 AM, Peter Maydell wrote: > >> On 2 March 2016 at 15:55, Markus Armbruster wrote: >>> I'd call it mac-keys.h. mackeys.h would be okay. There's enough >>> precedence for '_' in file names to justify mac_keys.h, but I per

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

2016-03-02 Thread Programmingkid
On Mar 2, 2016, at 11:45 AM, Peter Maydell wrote: > On 2 March 2016 at 15:55, Markus Armbruster wrote: >> I'd call it mac-keys.h. mackeys.h would be okay. There's enough >> precedence for '_' in file names to justify mac_keys.h, but I personally >> dislike that. > > Calling it adb-keys.h woul

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

2016-03-02 Thread Programmingkid
On Mar 2, 2016, at 11:45 AM, Peter Maydell wrote: > On 2 March 2016 at 15:55, Markus Armbruster wrote: >> I'd call it mac-keys.h. mackeys.h would be okay. There's enough >> precedence for '_' in file names to justify mac_keys.h, but I personally >> dislike that. > > Calling it adb-keys.h woul

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

2016-03-02 Thread Peter Maydell
On 2 March 2016 at 15:55, Markus Armbruster wrote: > I'd call it mac-keys.h. mackeys.h would be okay. There's enough > precedence for '_' in file names to justify mac_keys.h, but I personally > dislike that. Calling it adb-keys.h would make it clearer that what we're defining here are the scanc

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

2016-03-02 Thread Eric Blake
On 03/02/2016 08:55 AM, Markus Armbruster wrote: >>> >>> Please stick to lower case in file names. >> >> Which one do you prefer: mackeys.h or macKeys.h ? > > I'd call it mac-keys.h. mackeys.h would be okay. There's enough > precedence for '_' in file names to justify mac_keys.h, but I persona

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

2016-03-02 Thread Markus Armbruster
Programmingkid writes: > On Mar 2, 2016, at 4:32 AM, Markus Armbruster wrote: > >> Programmingkid writes: >> >>> This patch adds the file MacKeys.h. It is a file that contains all the >>> constants >>> for the Macintosh keyboard keycodes. >>> >>> Signed-off-by: John Arbuckle >>> >>> --- >>>

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

2016-03-02 Thread Programmingkid
On Mar 2, 2016, at 4:32 AM, Markus Armbruster wrote: > Programmingkid writes: > >> This patch adds the file MacKeys.h. It is a file that contains all the >> constants >> for the Macintosh keyboard keycodes. >> >> Signed-off-by: John Arbuckle >> >> --- >> Added standard license. >> Added #if

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

2016-03-02 Thread Markus Armbruster
Programmingkid writes: > This patch adds the file MacKeys.h. It is a file that contains all the > constants > for the Macintosh keyboard keycodes. > > Signed-off-by: John Arbuckle > > --- > Added standard license. > Added #ifndef #define #endif macros. > > include/hw/input/MacKeys.h | 168 >

[Qemu-devel] [PATCH v2] MacKeys.h: initial commit

2016-03-01 Thread Programmingkid
This patch adds the file MacKeys.h. It is a file that contains all the constants for the Macintosh keyboard keycodes. Signed-off-by: John Arbuckle --- Added standard license. Added #ifndef #define #endif macros. include/hw/input/MacKeys.h | 168 1