[Qemu-devel] [PATCH v2] We should check the virtio_load return code

2012-03-01 Thread Orit Wasserman
Otherwise we crash on error. Instruction to reporduce the crash with migration: 1) run a guest with -device virtio-blk-pci,drive=drive_name,scsi=on 2) run destination with -device virtio-blk-pci,drive=drive_name,scsi=off ... -incoming ... 3) migrate from 1 to 2. Signed-off-by: Ulrich Obergfell

Re: [Qemu-devel] [PATCH v2] We should check the virtio_load return code

2012-03-01 Thread Amit Shah
On (Thu) 01 Mar 2012 [13:28:08], Orit Wasserman wrote: Otherwise we crash on error. Instruction to reporduce the crash with migration: 1) run a guest with -device virtio-blk-pci,drive=drive_name,scsi=on 2) run destination with -device virtio-blk-pci,drive=drive_name,scsi=off ... -incoming

Re: [Qemu-devel] [PATCH v2] We should check the virtio_load return code

2012-03-01 Thread Michael S. Tsirkin
On Thu, Mar 01, 2012 at 01:28:08PM +0200, Orit Wasserman wrote: Otherwise we crash on error. Instruction to reporduce the crash with migration: 1) run a guest with -device virtio-blk-pci,drive=drive_name,scsi=on 2) run destination with -device virtio-blk-pci,drive=drive_name,scsi=off ...

Re: [Qemu-devel] [PATCH v2] We should check the virtio_load return code

2012-03-01 Thread Ulrich Obergfell
While I investigated and reproduced the problem, the qemu process itself did not crash/abort. I observed that a Linux guest (KVM virtual machine) became unresponsive after a migration because requests to a virtio disk did not complete. If virtio_load() returns via the following section of code