Re: [Qemu-devel] [PATCH v2] arm_gic_kvm: Disable live migration if not supported

2015-10-19 Thread Peter Maydell
On 16 October 2015 at 14:55, Pavel Fedin wrote: > Hello! > >> > +if (kvm_arm_gic_can_save_restore(s)) { >> > +kvm_arm_gic_put(s); >> > +} >> >> Why change the reset method in a patch that's dealing with adding >> a warning about migration? > > Since pre_save and post_load will ne

Re: [Qemu-devel] [PATCH v2] arm_gic_kvm: Disable live migration if not supported

2015-10-16 Thread Pavel Fedin
Hello! > > +if (kvm_arm_gic_can_save_restore(s)) { > > +kvm_arm_gic_put(s); > > +} > > Why change the reset method in a patch that's dealing with adding > a warning about migration? Since pre_save and post_load will never be called if migration is disabled, i removed unnecessa

[Qemu-devel] [PATCH v2] arm_gic_kvm: Disable live migration if not supported

2015-10-16 Thread Pavel Fedin
Currently, if the kernel does not have live migration API, the migration will still be attempted, but vGIC save/restore functions will just not do anything. This will result in a broken machine state. This patch fixes the problem by adding migration blocker if kernel API is not supported. Signed-

Re: [Qemu-devel] [PATCH v2] arm_gic_kvm: Disable live migration if not supported

2015-10-16 Thread Peter Maydell
On 16 October 2015 at 14:43, Pavel Fedin wrote: > Currently, if the kernel does not have live migration API, the migration > will still be attempted, but vGIC save/restore functions will just not do > anything. This will result in a broken machine state. > > This patch fixes the problem by adding