Re: [Qemu-devel] [PATCH v2] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2014-12-28 Thread Peter Maydell
On 28 December 2014 at 17:37, Programmingkid wrote: > On Dec 28, 2014, at 5:23 AM, Peter Maydell wrote: >> On 28 December 2014 at 03:00, Programmingkid >> wrote: >>> #if defined(__APPLE__) && defined(__MACH__) >>> -size = LLONG_MAX; >>> +#define IOCTL_ERROR_VALUE -1 >> >> You don

Re: [Qemu-devel] [PATCH v2] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2014-12-28 Thread Programmingkid
On Dec 28, 2014, at 5:23 AM, Peter Maydell wrote: > On 28 December 2014 at 03:00, Programmingkid > wrote: >> Here is version 2 of the patch. All the suggestions have been implemented. > > Thanks. > > Last round of nits, but the rest of the change is fine. > If you post v3 as its own email tha

Re: [Qemu-devel] [PATCH v2] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2014-12-28 Thread Peter Maydell
On 28 December 2014 at 03:00, Programmingkid wrote: > Here is version 2 of the patch. All the suggestions have been implemented. Thanks. Last round of nits, but the rest of the change is fine. If you post v3 as its own email that will make it easier to apply (most of our patch-handling tools ass

Re: [Qemu-devel] [PATCH v2] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2014-12-27 Thread Programmingkid
On Dec 27, 2014, at 8:19 PM, Peter Maydell wrote: > On 28 December 2014 at 00:36, Programmingkid > wrote: >> The raw_getlength() function under Mac OS X incorrectly returned a constant >> value instead of calculating the size of a real CD-ROM disc. This patch >> fixes this problem and makes b