Re: [Qemu-devel] [PATCH v2] blockdev: fix missed target unref for drive-backup

2019-05-22 Thread Kevin Wolf
Am 13.05.2019 um 17:06 hat John Snow geschrieben: > If the bitmap can't be used for whatever reason, we skip putting down > the reference. Fix that. > > In practice, this means that if you attempt to gracefully exit QEMU > after a backup command being rejected, bdrv_close_all will fail and > tell

Re: [Qemu-devel] [PATCH v2] blockdev: fix missed target unref for drive-backup

2019-05-20 Thread John Snow
On 5/13/19 11:06 AM, John Snow wrote: > If the bitmap can't be used for whatever reason, we skip putting down > the reference. Fix that. > > In practice, this means that if you attempt to gracefully exit QEMU > after a backup command being rejected, bdrv_close_all will fail and > tell you some

[Qemu-devel] [PATCH v2] blockdev: fix missed target unref for drive-backup

2019-05-13 Thread John Snow
If the bitmap can't be used for whatever reason, we skip putting down the reference. Fix that. In practice, this means that if you attempt to gracefully exit QEMU after a backup command being rejected, bdrv_close_all will fail and tell you some unpleasant things via assert(). Reported-by: aihua