Re: [Qemu-devel] [PATCH v2] bugfix: passing reference instead of value

>>> Separated from previous "igd-passthru convert to realize" patch. Since >>> these two don`t have dependency, can send it solely. >>> >>> Not test since it is easy to find out if reading carefully, just >>> compiled. This patch works but the added conversion to LE is conceptually wrong. The

Re: [Qemu-devel] [PATCH v2] bugfix: passing reference instead of value

Hi Paolo On 12/30/2015 12:25 AM, Paolo Bonzini wrote: Separated from previous "igd-passthru convert to realize" patch. Since these two don`t have dependency, can send it solely. Not test since it is easy to find out if reading carefully, just compiled. This patch works but the added

Re: [Qemu-devel] [PATCH v2] bugfix: passing reference instead of value

CC the code author: Tiejun Chen On 12/28/2015 12:42 PM, Cao jin wrote: Fix the bug introduced by 595a4f07: Function host_pci_config_read() should be passed by a reference, not a value, for the later pci_default_write_config(). And because value in PCI config space are

Re: [Qemu-devel] [PATCH v2] bugfix: passing reference instead of value

Oops, got following feedback 2nd time: The following message to was undeliverable. The reason for the problem: 5.1.0 - Unknown address error 550-'#5.1.0 Address rejected.' I guess the author address is not available anymore On 12/29/2015 07:54 PM, Cao jin wrote: CC the

[Qemu-devel] [PATCH v2] bugfix: passing reference instead of value

Fix the bug introduced by 595a4f07: Function host_pci_config_read() should be passed by a reference, not a value, for the later pci_default_write_config(). And because value in PCI config space are little-endian, use cpu_to_le32() to ensure it when write config. Signed-off-by: Cao jin