Re: [Qemu-devel] [PATCH v2] build: include sys/sysmacros.h for major() and minor()

2016-12-30 Thread Peter Maydell
On 29 December 2016 at 13:48, Eric Blake wrote: > On 12/28/2016 11:07 AM, Peter Maydell wrote: >> Also this seems straightforwardly like a bug in glibc: it shouldn't >> be making this kind of breaking change. makedev(3) on my Linux box >> says nothing about needing sysmacros.h

Re: [Qemu-devel] [PATCH v2] build: include sys/sysmacros.h for major() and minor()

2016-12-29 Thread Eric Blake
On 12/28/2016 11:07 AM, Peter Maydell wrote: > On 28 December 2016 at 16:10, Eric Blake wrote: >> On 12/28/2016 08:53 AM, Christopher Covington wrote: >>> The definition of the major() and minor() macros are moving within glibc to >>> . Include this header to avoid the

Re: [Qemu-devel] [PATCH v2] build: include sys/sysmacros.h for major() and minor()

2016-12-28 Thread Christopher Covington
Hi Eric, On 12/28/2016 11:10 AM, Eric Blake wrote: > On 12/28/2016 08:53 AM, Christopher Covington wrote: >> The definition of the major() and minor() macros are moving within glibc to >> . Include this header to avoid the following sorts of >> build-stopping messages: >> > >> The additional

Re: [Qemu-devel] [PATCH v2] build: include sys/sysmacros.h for major() and minor()

2016-12-28 Thread Peter Maydell
On 28 December 2016 at 16:10, Eric Blake wrote: > On 12/28/2016 08:53 AM, Christopher Covington wrote: >> The definition of the major() and minor() macros are moving within glibc to >> . Include this header to avoid the following sorts of >> build-stopping messages: >> > >> The

Re: [Qemu-devel] [PATCH v2] build: include sys/sysmacros.h for major() and minor()

2016-12-28 Thread Eric Blake
On 12/28/2016 08:53 AM, Christopher Covington wrote: > The definition of the major() and minor() macros are moving within glibc to > . Include this header to avoid the following sorts of > build-stopping messages: > > The additional include allows the build to complete on Fedora 26 (Rawhide) >

[Qemu-devel] [PATCH v2] build: include sys/sysmacros.h for major() and minor()

2016-12-28 Thread Christopher Covington
The definition of the major() and minor() macros are moving within glibc to . Include this header to avoid the following sorts of build-stopping messages: qga/commands-posix.c: In function ‘dev_major_minor’: qga/commands-posix.c:656:13: error: In the GNU C Library, "major" is defined by . For