Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-31 Thread Peter Maydell
On 31 October 2017 at 18:08, Stefano Stabellini wrote: > On Tue, 31 Oct 2017, Peter Maydell wrote: >> On 31 October 2017 at 17:07, Stefano Stabellini >> wrote: >> > Sorry Peter, I copy/pasted the values from arm32/page.h instead of >> > arm64/page.h in Xen :-/ >> > >> > Xen is running at EL2, 64

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 31 October 2017 at 17:07, Stefano Stabellini > wrote: > > Sorry Peter, I copy/pasted the values from arm32/page.h instead of > > arm64/page.h in Xen :-/ > > > > Xen is running at EL2, 64-bit (aarch64). The ATS instruction is "at > > s1e2r", used to t

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-31 Thread Peter Maydell
On 31 October 2017 at 17:07, Stefano Stabellini wrote: > Sorry Peter, I copy/pasted the values from arm32/page.h instead of > arm64/page.h in Xen :-/ > > Xen is running at EL2, 64-bit (aarch64). The ATS instruction is "at > s1e2r", used to translate Xen virtual addresses into physical addresses. >

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 30 October 2017 at 22:57, Stefano Stabellini > wrote: > > On Mon, 30 Oct 2017, Peter Maydell wrote: > >> What's the specific situation/bug that you're trying to fix with > >> this patch? You don't say in the commit message. > >> We should be able to

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-31 Thread Peter Maydell
On 30 October 2017 at 22:57, Stefano Stabellini wrote: > On Mon, 30 Oct 2017, Peter Maydell wrote: >> What's the specific situation/bug that you're trying to fix with >> this patch? You don't say in the commit message. >> We should be able to put in a point fix to deal with whatever it is, >> but

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-30 Thread Stefano Stabellini
On Mon, 30 Oct 2017, Peter Maydell wrote: > On 26 October 2017 at 00:28, Stefano Stabellini > wrote: > > extended_addresses_enabled calls arm_el_is_aa64, hardcoding exception > > level 1. Instead, add an additional "el" argument to > > extended_addresses_enabled. > > > > The caller will pass the

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-30 Thread Peter Maydell
On 26 October 2017 at 00:28, Stefano Stabellini wrote: > extended_addresses_enabled calls arm_el_is_aa64, hardcoding exception > level 1. Instead, add an additional "el" argument to > extended_addresses_enabled. > > The caller will pass the right value. In most cases, it will be > arm_current_el(e

[Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-25 Thread Stefano Stabellini
extended_addresses_enabled calls arm_el_is_aa64, hardcoding exception level 1. Instead, add an additional "el" argument to extended_addresses_enabled. The caller will pass the right value. In most cases, it will be arm_current_el(env). However, arm_debug_excp_handler will use arm_debug_target_el(e