Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-27 Thread Auger Eric
Hi Paolo, On 06/27/2018 10:26 AM, Paolo Bonzini wrote: > On 26/06/2018 22:29, Auger Eric wrote: >>> >>> Fixes: 48564041a73a (exec: reintroduce MemoryRegion caching) >>> Signed-off-by: Eric Auger >> gentle reminder, just to make sure someone is going to pick up this >> patch before the freeze ;-)

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-27 Thread Paolo Bonzini
On 26/06/2018 22:29, Auger Eric wrote: >> >> Fixes: 48564041a73a (exec: reintroduce MemoryRegion caching) >> Signed-off-by: Eric Auger > gentle reminder, just to make sure someone is going to pick up this > patch before the freeze ;-) Or please let me know if I miss some concerns. Yes, it's alrea

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-26 Thread Auger Eric
Hi, On 06/13/2018 03:19 PM, Eric Auger wrote: > When an IOMMUMemoryRegion is in front of a virtio device, > address_space_cache_init does not set cache->ptr as the memory > region is not RAM. However when the device performs an access, > we end up in glue() which performs the translation and then

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-14 Thread Auger Eric
Hi Peter, On 06/14/2018 03:52 AM, Peter Xu wrote: > On Wed, Jun 13, 2018 at 04:20:34PM +0200, Auger Eric wrote: >> Hi Paolo, >> >> On 06/13/2018 03:53 PM, Paolo Bonzini wrote: >>> On 13/06/2018 15:44, Auger Eric wrote: > Queuing this patch. I'm not sure how I missed this, I have actually

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Peter Xu
On Wed, Jun 13, 2018 at 04:20:34PM +0200, Auger Eric wrote: > Hi Paolo, > > On 06/13/2018 03:53 PM, Paolo Bonzini wrote: > > On 13/06/2018 15:44, Auger Eric wrote: > >>> Queuing this patch. I'm not sure how I missed this, I have actually > >>> tested it with SMMU. > >> no problem. Strange also I

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Auger Eric
Hi Paolo, On 06/13/2018 03:53 PM, Paolo Bonzini wrote: > On 13/06/2018 15:44, Auger Eric wrote: >>> Queuing this patch. I'm not sure how I missed this, I have actually >>> tested it with SMMU. >> no problem. Strange also I was the only one facing the issue. > > No, I must have blundered it betwe

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 15:44, Auger Eric wrote: >> Queuing this patch. I'm not sure how I missed this, I have actually >> tested it with SMMU. > no problem. Strange also I was the only one facing the issue. No, I must have blundered it between testing and posting the patches. >> Do you also need the MemT

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Auger Eric
Hi Paolo, On 06/13/2018 03:36 PM, Paolo Bonzini wrote: > On 13/06/2018 15:19, Eric Auger wrote: >> When an IOMMUMemoryRegion is in front of a virtio device, >> address_space_cache_init does not set cache->ptr as the memory >> region is not RAM. However when the device performs an access, >> we end

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 15:19, Eric Auger wrote: > When an IOMMUMemoryRegion is in front of a virtio device, > address_space_cache_init does not set cache->ptr as the memory > region is not RAM. However when the device performs an access, > we end up in glue() which performs the translation and then uses > M

[Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Eric Auger
When an IOMMUMemoryRegion is in front of a virtio device, address_space_cache_init does not set cache->ptr as the memory region is not RAM. However when the device performs an access, we end up in glue() which performs the translation and then uses MAP_RAM. This latter uses the unset ptr and return