[Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

2017-06-13 Thread Vadim Galitsyn
Commands above provide the following memory information in bytes: * base-memory - amount of static memory specified with '-m' option at the start of the QEMU process. * hot-plug-memory - amount of memory that was hot-plugged. * ballooned-actual-memory - size of the memory that remains

Re: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

2017-06-13 Thread Fam Zheng
On Tue, 06/13 07:59, no-re...@patchew.org wrote: > In file included from /tmp/qemu-test/src/hw/net/vmxnet3.c:30: > /tmp/qemu-test/src/include/migration/register.h:18: error: redefinition of > typedef ‘LoadStateHandler’ > /tmp/qemu-test/src/include/migration/vmstate.h:32: note: previous declaration

Re: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

2017-06-14 Thread Dr. David Alan Gilbert
* Vadim Galitsyn (vadim.galit...@profitbricks.com) wrote: > Commands above provide the following memory information in bytes: > > * base-memory - amount of static memory specified > with '-m' option at the start of the QEMU process. > > * hot-plug-memory - amount of memory that was hot-pl

Re: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

2017-06-14 Thread Vadim Galitsyn
Hi Dave, Thank you for the feedback! > I think you need to use the PRIu64 macros rather than 'lu' for the types > of the ints there to keep it portable. Agree, patch v3 will include this change. > Other than that; please add a test entry to tests/test-hmp.c > and I'm guessing you'll also need a

Re: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

2017-06-14 Thread Dr. David Alan Gilbert
* Vadim Galitsyn (vadim.galit...@profitbricks.com) wrote: > Hi Dave, > > Thank you for the feedback! > > > I think you need to use the PRIu64 macros rather than 'lu' for the types > > of the ints there to keep it portable. > > Agree, patch v3 will include this change. Thanks. > > Other than th

Re: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

2017-06-20 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Vadim Galitsyn (vadim.galit...@profitbricks.com) wrote: >> Hi Dave, >> >> Thank you for the feedback! >> >> > I think you need to use the PRIu64 macros rather than 'lu' for the types >> > of the ints there to keep it portable. >> >> Agree, patch v3 will inc

Re: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

2017-06-22 Thread Vadim Galitsyn
Hi Markus, Thank you for the input. > However, your query-memory looks like it could fail. With the latest version of a patch ( http://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg03475.html) "query-memory" can fail only in two cases: a) if in QOM there is an object of type of TYPE_PC_DI

Re: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

2017-06-22 Thread Markus Armbruster
Vadim Galitsyn writes: > Hi Markus, > > Thank you for the input. > >> However, your query-memory looks like it could fail. > > With the latest version of a patch ( > http://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg03475.html) > "query-memory" can fail only in two cases: > > a) if in QO

Re: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170613140546.28227-1-vadim.galit...@profitbricks.com Subject: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "