Re: [Qemu-devel] [PATCH v2] hw/ide: Remove duplicated definitions from ahci_internal.h

2018-01-19 Thread John Snow
On 12/07/2017 12:47 AM, Thomas Huth wrote: > On 06.12.2017 23:16, John Snow wrote: >> I tweaked this again, sorry: >> >> The names need to stay public, but the wrappers to manipulate the >> objects can stay internal. Minor difference. >> >> If that's okay, I'll just merge this in. >> OK? > > Sur

Re: [Qemu-devel] [PATCH v2] hw/ide: Remove duplicated definitions from ahci_internal.h

2017-12-08 Thread John Snow
On 12/05/2017 02:10 AM, Thomas Huth wrote: > The same definitions can also be found in include/hw/ide/ahci.h > so let's remove these #defines from ahci_internal.h. > > Signed-off-by: Thomas Huth > --- > v2: Also remove TYPE_ICH9_AHCI as suggested by John > > hw/ide/ahci_internal.h | 12 -

Re: [Qemu-devel] [PATCH v2] hw/ide: Remove duplicated definitions from ahci_internal.h

2017-12-06 Thread Thomas Huth
On 06.12.2017 23:16, John Snow wrote: > I tweaked this again, sorry: > > The names need to stay public, but the wrappers to manipulate the > objects can stay internal. Minor difference. > > If that's okay, I'll just merge this in. > OK? Sure. Feel also free to replace my "Signed-off-by" with "Re

Re: [Qemu-devel] [PATCH v2] hw/ide: Remove duplicated definitions from ahci_internal.h

2017-12-06 Thread John Snow
I tweaked this again, sorry: The names need to stay public, but the wrappers to manipulate the objects can stay internal. Minor difference. If that's okay, I'll just merge this in. OK? --js diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h index ce2e818c8c..8c755d4ca1 100644 --- a/hw

[Qemu-devel] [PATCH v2] hw/ide: Remove duplicated definitions from ahci_internal.h

2017-12-04 Thread Thomas Huth
The same definitions can also be found in include/hw/ide/ahci.h so let's remove these #defines from ahci_internal.h. Signed-off-by: Thomas Huth --- v2: Also remove TYPE_ICH9_AHCI as suggested by John hw/ide/ahci_internal.h | 12 1 file changed, 12 deletions(-) diff --git a/hw/ide