Hi Eduardo,
At 07/10/2018 06:27 PM, Eduardo Habkost wrote:
On Tue, Jul 10, 2018 at 04:15:30PM +0800, Dou Liyang wrote:
[...]
+if (nb_numa_nodes)
machine_numa_finish_cpu_init(machine);
-}
missing curly brackets, should look like:
if (nb_numa_nodes) {
mac
On Tue, Jul 10, 2018 at 04:15:30PM +0800, Dou Liyang wrote:
[...]
> > > +if (nb_numa_nodes)
> > > machine_numa_finish_cpu_init(machine);
> > > -}
> > missing curly brackets, should look like:
> > if (nb_numa_nodes) {
> > machine_numa_finish_cpu_init(machine);
>
Hi Igor,
At 07/10/2018 03:42 PM, Igor Mammedov wrote:
On Wed, 4 Jul 2018 21:22:39 +0800
Dou Liyang wrote:
Commit 7a3099fc9c5c("numa: postpone options post-processing till
machine_run_board_init()")
broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly").
The machine_run_bo
On Wed, 4 Jul 2018 21:22:39 +0800
Dou Liyang wrote:
> Commit 7a3099fc9c5c("numa: postpone options post-processing till
> machine_run_board_init()")
> broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly").
>
> The machine_run_board_init() doesn't do NUMA setup if nb_numa_node
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180704132239.6506-1-douly.f...@cn.fujitsu.com
Subject: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of
nb_numa_nodes for numa_complete_configuration
On Wed, Jul 04, 2018 at 09:22:39PM +0800, Dou Liyang wrote:
> Commit 7a3099fc9c5c("numa: postpone options post-processing till
> machine_run_board_init()")
> broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly").
>
> The machine_run_board_init() doesn't do NUMA setup if nb_num
Commit 7a3099fc9c5c("numa: postpone options post-processing till
machine_run_board_init()")
broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly").
The machine_run_board_init() doesn't do NUMA setup if nb_numa_nodes=0,
but the numa_complete_configuration need add a new node if
