Re: [Qemu-devel] [PATCH v2] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-23 Thread David Gibson
On Tue, Apr 21, 2015 at 05:12:11PM +0200, Thomas Huth wrote: > The check "liobn & 0xULL" in spapr_tce_find_by_liobn() > is completely useless since liobn is only declared as an uint32_t > parameter. Fix this by using target_ulong instead (this is what most > of the callers of this f

[Qemu-devel] [PATCH v2] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-21 Thread Thomas Huth
The check "liobn & 0xULL" in spapr_tce_find_by_liobn() is completely useless since liobn is only declared as an uint32_t parameter. Fix this by using target_ulong instead (this is what most of the callers of this function are using, too). Signed-off-by: Thomas Huth --- v2: - Do no