Re: [Qemu-devel] [PATCH v2] iotests: fix wait_until_completed()

2018-04-10 Thread Peter Xu
On Mon, Apr 09, 2018 at 09:06:59AM -0500, Eric Blake wrote: > On 04/07/2018 10:05 PM, Peter Xu wrote: > > If there are more than one events, wait_until_completed() might return > > the 2nd event even if the 1st event is JOB_COMPLETED, since the for loop > > will continue to run even if completed

Re: [Qemu-devel] [PATCH v2] iotests: fix wait_until_completed()

2018-04-09 Thread Eric Blake
On 04/07/2018 10:05 PM, Peter Xu wrote: > If there are more than one events, wait_until_completed() might return > the 2nd event even if the 1st event is JOB_COMPLETED, since the for loop > will continue to run even if completed is set to True. > > It never happened before, but it can be

Re: [Qemu-devel] [PATCH v2] iotests: fix wait_until_completed()

2018-04-09 Thread Stefan Hajnoczi
On Sun, Apr 08, 2018 at 11:05:42AM +0800, Peter Xu wrote: > If there are more than one events, wait_until_completed() might return > the 2nd event even if the 1st event is JOB_COMPLETED, since the for loop > will continue to run even if completed is set to True. > > It never happened before, but

Re: [Qemu-devel] [PATCH v2] iotests: fix wait_until_completed()

2018-04-08 Thread Fam Zheng
On Sun, 04/08 11:05, Peter Xu wrote: > If there are more than one events, wait_until_completed() might return > the 2nd event even if the 1st event is JOB_COMPLETED, since the for loop > will continue to run even if completed is set to True. > > It never happened before, but it can be triggered

[Qemu-devel] [PATCH v2] iotests: fix wait_until_completed()

2018-04-07 Thread Peter Xu
If there are more than one events, wait_until_completed() might return the 2nd event even if the 1st event is JOB_COMPLETED, since the for loop will continue to run even if completed is set to True. It never happened before, but it can be triggered when OOB is enabled due to the RESUME startup